Close bullet list after hitting enter on empty list line#328
Open
Calamari wants to merge 3 commits intorefactory-id:masterfrom
Open
Close bullet list after hitting enter on empty list line#328Calamari wants to merge 3 commits intorefactory-id:masterfrom
Calamari wants to merge 3 commits intorefactory-id:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I like this convenience on every markdown editor I go, I thought I add this here too. This adds the following behavior:
Hitting enter on empty list rows, will close the (numbered) bullet list.
Here an example:
When having the following content in a textarea (
|is representing the caret):After hitting enter the content will now look like this:
instead of this:
I added the same for numbered bullet lists.
As a bonus, I also fixed the bug, that hitting enter on a line like
9.will misplace the caret about one character, since the length of the old number was used, instead of the added10..Note about testing:
Since there are no tests in this repository, I tested all the cases I could come up with manually.
If something is missing, or you want to have something changed. I am eager to do it. I would like to have this feature in. :)