Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,19 +71,19 @@ Example output:
BITCOINUI REVIEW: SendFeeView.swift
===============================================

SERIOUS (1 issue)
MEDIUM (1 issue)
------------------
[UX] Line 88: Fee picker lacks a high-fee warning
Fix: Add a warning when fee >= 50% of amount.
Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

MODERATE (1 issue)
LOW (1 issue)
------------------
[A11Y] Line 42: Icon-only close button has no label
Fix: Add accessibilityLabel("Close")
Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

===============================================
SUMMARY: 0 critical, 1 serious, 1 moderate, 0 info
SUMMARY: 0 high, 1 medium, 1 low
===============================================
```
16 changes: 6 additions & 10 deletions commands/bitcoinui.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,35 +31,31 @@ If `$ARGUMENTS` is empty, ask: "Using the bitcoinui command for an iOS review. W
## Output Format

Start directly with the `BITCOINUI REVIEW` block; do not add any preamble text before it.
Omit any severity section with 0 issues (including INFO).
Omit any severity section with 0 issues (including LOW).

```
===============================================
BITCOINUI REVIEW: [filename]
===============================================

CRITICAL (X issues)
HIGH (X issues)
------------------
[UX] Line 42: Missing warning for fee > amount
Fix: Add a warning state when fee >= 50% of amount.
Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

SERIOUS (X issues)
MEDIUM (X issues)
------------------
[A11Y] Line 18: Icon-only button has no label
Fix: Add accessibilityLabel("Close")
Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

MODERATE (X issues)
LOW (X issues)
------------------
...

INFO (X issues)
--------------
...

===============================================
SUMMARY: X critical, X serious, X moderate, X info
SUMMARY: X high, X medium, X low
===============================================
```

Expand All @@ -71,5 +67,5 @@ SUMMARY: X critical, X serious, X moderate, X info
4. Include a direct URL in each Reference line.
5. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Reference line.
6. Suggest BitcoinUI components when they fit the pattern.
7. INFO is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
7. LOW is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
8. Do not modify code unless asked; offer to fix if appropriate.
16 changes: 6 additions & 10 deletions site/bitcoinui.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,35 +31,31 @@ If `$ARGUMENTS` is empty, ask: "Using the bitcoinui command for an iOS review. W
## Output Format

Start directly with the `BITCOINUI REVIEW` block; do not add any preamble text before it.
Omit any severity section with 0 issues (including INFO).
Omit any severity section with 0 issues (including LOW).

```
===============================================
BITCOINUI REVIEW: [filename]
===============================================

CRITICAL (X issues)
HIGH (X issues)
------------------
[UX] Line 42: Missing warning for fee > amount
Fix: Add a warning state when fee >= 50% of amount.
Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

SERIOUS (X issues)
MEDIUM (X issues)
------------------
[A11Y] Line 18: Icon-only button has no label
Fix: Add accessibilityLabel("Close")
Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

MODERATE (X issues)
LOW (X issues)
------------------
...

INFO (X issues)
--------------
...

===============================================
SUMMARY: X critical, X serious, X moderate, X info
SUMMARY: X high, X medium, X low
===============================================
```

Expand All @@ -71,5 +67,5 @@ SUMMARY: X critical, X serious, X moderate, X info
4. Include a direct URL in each Reference line.
5. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Reference line.
6. Suggest BitcoinUI components when they fit the pattern.
7. INFO is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
7. LOW is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
8. Do not modify code unless asked; offer to fix if appropriate.
6 changes: 3 additions & 3 deletions site/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@ <h2><a href="https://opencode.ai/docs/commands/">OpenCode</a></h2>
<p class="note">INSTALL -&gt; RUN BITCOINUI -&gt; GET A DESIGN REVIEW</p>
<pre class="output-block"><code>BITCOINUI REVIEW: SendFeeView.swift
===================================
SERIOUS (1 issue)
----------------
MEDIUM (1 issue)
---------------
[UX] Line 88: Fee picker lacks a high-fee warning
Fix: Add a warning when fee &gt;= 50% of amount.
Reference: Bitcoin Design Guide - Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/
SUMMARY: 0 critical, 1 serious, 0 moderate</code></pre>
SUMMARY: 0 high, 1 medium, 0 low</code></pre>
</section>
</div>

Expand Down
22 changes: 9 additions & 13 deletions site/skills/bitcoinui/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,43 +21,39 @@ Review iOS SwiftUI code and screens for Bitcoin-specific UX correctness, iOS HIG
2. Apply the rubric in `references/bitcoinui-rubric.md`.
3. Report issues by severity with line numbers, a short snippet, and a concrete fix. Include a direct URL in each Reference line.
4. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Reference line.
4. Suggest BitcoinUI components when they would reduce errors or improve consistency.
5. Omit any severity section with 0 issues (including INFO).
6. INFO is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
7. Do not modify code unless the user asks; offer to fix if appropriate.
5. Suggest BitcoinUI components when they would reduce errors or improve consistency.
6. Omit any severity section with 0 issues (including LOW).
7. LOW is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
8. Do not modify code unless the user asks; offer to fix if appropriate.

## Output Format

Start directly with the `BITCOINUI REVIEW` block; do not add any preamble text before it.
Omit any severity section with 0 issues (including INFO).
Omit any severity section with 0 issues (including LOW).

```
===============================================
BITCOINUI REVIEW: [filename]
===============================================

CRITICAL (X issues)
HIGH (X issues)
------------------
[UX] Line 42: Missing warning for fee > amount
Fix: Add a warning state when fee >= 50% of amount.
Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

SERIOUS (X issues)
MEDIUM (X issues)
------------------
[A11Y] Line 18: Icon-only button has no label
Fix: Add accessibilityLabel("Close")
Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

MODERATE (X issues)
LOW (X issues)
------------------
...

INFO (X issues)
--------------
...

===============================================
SUMMARY: X critical, X serious, X moderate, X info
SUMMARY: X high, X medium, X low
===============================================
```

Expand Down
22 changes: 9 additions & 13 deletions skills/bitcoinui/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,43 +21,39 @@ Review iOS SwiftUI code and screens for Bitcoin-specific UX correctness, iOS HIG
2. Apply the rubric in `references/bitcoinui-rubric.md`.
3. Report issues by severity with line numbers, a short snippet, and a concrete fix. Include a direct URL in each Reference line.
4. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Reference line.
4. Suggest BitcoinUI components when they would reduce errors or improve consistency.
5. Omit any severity section with 0 issues (including INFO).
6. INFO is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
7. Do not modify code unless the user asks; offer to fix if appropriate.
5. Suggest BitcoinUI components when they would reduce errors or improve consistency.
6. Omit any severity section with 0 issues (including LOW).
7. LOW is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
8. Do not modify code unless the user asks; offer to fix if appropriate.

## Output Format

Start directly with the `BITCOINUI REVIEW` block; do not add any preamble text before it.
Omit any severity section with 0 issues (including INFO).
Omit any severity section with 0 issues (including LOW).

```
===============================================
BITCOINUI REVIEW: [filename]
===============================================

CRITICAL (X issues)
HIGH (X issues)
------------------
[UX] Line 42: Missing warning for fee > amount
Fix: Add a warning state when fee >= 50% of amount.
Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

SERIOUS (X issues)
MEDIUM (X issues)
------------------
[A11Y] Line 18: Icon-only button has no label
Fix: Add accessibilityLabel("Close")
Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

MODERATE (X issues)
LOW (X issues)
------------------
...

INFO (X issues)
--------------
...

===============================================
SUMMARY: X critical, X serious, X moderate, X info
SUMMARY: X high, X medium, X low
===============================================
```

Expand Down
7 changes: 3 additions & 4 deletions skills/bitcoinui/references/bitcoinui-rubric.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@

## Severity

- Critical: could cause loss of funds, irreversible mistakes, or misleading safety.
- Serious: likely user error, accessibility blockers, or major HIG violations.
- Moderate: clarity or consistency issues.
- Info: polish suggestions.
- High: could cause loss of funds, irreversible mistakes, or misleading safety.
- Medium: likely user error, accessibility blockers, or major HIG violations.
- Low: clarity or consistency issues and polish suggestions.

## Bitcoin-Specific Checks

Expand Down