Reorder arguments if block given and no encoding needed#21
Open
mirko314 wants to merge 1 commit intoreed:masterfrom
Open
Reorder arguments if block given and no encoding needed#21mirko314 wants to merge 1 commit intoreed:masterfrom
mirko314 wants to merge 1 commit intoreed:masterfrom
Conversation
|
I just hit this as well and can confirm the fix resolves the issue for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one tries to use the vanilla mail_to through the gem, the arguments will get messed up if used with a block. This is due to line 48 which is executed in the gem as well as in the super, messing up the order of arguments.
We effectively need to reverse line 48 if we want to call the super, otherwise the html_options will not be passed to the super.