fix: mock server refusing connections #124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the mock sever that is use when `PACT_USE_MOCKING_SERVER=yes`. Adds a notification mechanism so that the mock server is started and listening before interactions begin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the mock server that is use when
PACT_USE_MOCKING_SERVER=yes.Said mock server is run in a separate process, and if the process isn't bound to the port yet, connections will be refused.
This adds a notification mechanism so that the mock server is started and listening before any interactions begin.
Specifically, it hooks into the server_activate() in HTTPServer's base class
I'm aware that this pull request is unlikely to be merged as the repo has no recent activity. But perhaps this fix is useful to a potential future forker.