Don't access property getters in Remove methods #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
Still getting ObjectDisposedExceptions, which got better in #118, however still reproducible in some cases.
🆕 What is the new behavior (if this is a feature change)?
Fixed access to properties in Remove methods which would trigger implicit initialization of various views and attempt to access disposed references.
Also nulling out HudWindow in the remove hud method to avoid accessing a disposed instance of it.
💥 Does this PR introduce a breaking change?
Nope
🐛 Recommendations for testing
📝 Links to relevant issues/docs
Fixes #117
🤔 Checklist before submitting