Skip to content

Conversation

@adrianmgg
Copy link
Contributor

worked on getting this building on windows for me to investigate the issue w/ data explorer not launching, made a few improvements to the windows build scripts too while i was in there.

changes:

  • switch Configure helper function to use a list of args instead of a single string, so that e.g. paths with spaces won't break it (?probably at least, I didn't actually have any spaces in the paths of mine so idk)
  • move breeze-icons build to above kiconthemes, since build for the latter was failing from the former not being there yet
  • skip re-downloading zips if they've already been downloaded (same as how cloning of git repos was already handled)
  • added one stray include that was missing
  • change copied dll name from zlibd.dll to zd.dll
  • add copying of qsqlited.dll which is required for DataExplorer (this closes Data Explorer fails to launch #20 and i can confirm DataExplorer built after making this change launches for me)

a couple other notes from stuff i ran into, but which aren't changed in this PR:

  • windows-build.ps1 needs QTDIR environment variable to be set, not mentioned in BUILDING.md
  • Qt 9 was the lowest version that worked (QT_MIN_VERSION is 8 and BUILDING.md mentions Qt 6)
  • needs a python version with lxml installed (the CI scripts already handle this but the build docs should probably mention it for manual builds)
  • the copying over of the sqlite dll would also need to be added to the CI scripts, I only added it to the powershell build script here

- switch Configure helper function to use a list of args instead of a single string, so that paths with spaces won't break it (?probably at least, I didn't actually have any spaces in the paths of mine so it didn't actually matter in the end)
- move `breeze-icons` build to above `kiconthemes`, since build for the latter will fail if the former isn't there yet
- skip re-downloading zips if they've already been downloaded (same as how cloning of git repos was already handled)
- added one stray include that was missing
- change copied dll name from zlibd.dll to zd.dll
- add copying of qsqlited.dll which is required for DataExplorer
@redstrate
Copy link
Owner

Thanks for updating the script, I appreciate it!

a couple other notes from stuff i ran into, but which aren't changed in this PR:

Opened a follow-up issue in #24, those are stuff fixable by me and can be done later.

@redstrate redstrate merged commit b56f821 into redstrate:main Jan 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data Explorer fails to launch

2 participants