Update mira.py #75
Open
Update mira.py #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new instr
flags for zlib etc
Line 6 doesn't work, but there are two possible reasons (and possible fixes). Either A) the test should be looking for the build decoder in $cdec/build/decoder/cdec instead of in $cdec/decoder/cdec. or B) the "make -j4" command should be creating a decoder executable at $cdec/decoder/cdec , but isn't. I assumed (A), because it's simpler.
Update run-system-tests.pl
Neither $cdec/training/utils/decode-and-evaluate.pl nor $cdec/training/utils/parallelize.pl get copied to the build directory $cdec/build/training/utils/ They probably should be (along with everything else in the directory), but until then mira.py needs to look one directory level further up to find them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither $cdec/training/utils/decode-and-evaluate.pl nor $cdec/training/utils/parallelize.pl get copied to the build directory $cdec/build/training/utils/
They probably should be (along with everything else in the directory), but until then mira.py needs to look one directory level further up to find them.