Open
Conversation
…eanup by setting the Disconnect behavior, disabled point-by-point drawing as this seems to be a non-issue and not doing it gives a significant speed boost. Could be that the segfault detected earlier was bieng confused for a drawing problem. Also modified the cmake file by adding the flag -gstabs+ to the debug compiler flags if project is being built in a Unix environment.
…eanup by setting the Disconnect behavior, disabled point-by-point drawing as this seems to be a non-issue and not doing it gives a significant speed boost. Could be that the segfault detected earlier was bieng confused for a drawing problem. Also modified the cmake file by adding the flag -gstabs+ to the debug compiler flags if project is being built in a Unix environment.
…eanup by setting the Disconnect behavior, disabled point-by-point drawing as this seems to be a non-issue and not doing it gives a significant speed boost. Could be that the segfault detected earlier was bieng confused for a drawing problem. Also modified the cmake file by adding the flag -gstabs+ to the debug compiler flags if project is being built in a Unix environment. Added *.kate-swp to .gitignore to ignore future kate swap files from slipping into the repo that are sure to turn up accidently.
…om sneaking into the repo in the future
…ng in maya now, use the commit before this one which is on redpawfx branch untill it can be tracked down
… changes, added other drawing styles back in to draw function
…/debug Conflicts: contrib/partio4Maya/partioVisualizer.cpp contrib/partio4Maya/partioVisualizer.h
…rayDataBuilder, only changed for the visualizer waiting to propigate to see if it resolves segfault issue
…called with a pointer to a no longer valid MObject instance
…l of callback with a pointer to a no longer valid MObject Node reference
…point draw method do set matrix staticly instead of in a double loop
This was a branch to track down some segfaults occuring in some use cases main changes are. Now use MArrayDataBuilder and MArrayDataHandle to clean partio attribute arrays Did some style unification amongst contrib files Moved all includes to header files with associated ifndef and define to prevent multiple includes Added some more comments to each node Did some significant refactoring of partioVisualizer code, the previous vs current state is now kept in a PartioVizState struct and then current context vars are in a Context struct Made some preprocessor defines for draw styles Split up the compute function into smaller chunks as helper functions Made slight modifications to the draw code Moved callbackID's into class variables
ghost
assigned
Owner
|
Awesome, Thanks! I'm going to slowly merge these fixes in, starting with just the stuff that improves stability, vs refactoring changes right now since I am actually 2 weeks late in my "siggraph" release :-) And I don't want to introduce any errant refactoring bugs until I can get some production testing behind it. Then I can spend some more time refactoring testing and cleaning up all the dusty corners of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a branch to track down some segfaults occuring in some use cases main changes are.
Now use MArrayDataBuilder and MArrayDataHandle to clean partio attribute arrays
Did some style unification amongst contrib files
Moved all includes to header files with associated ifndef and define to prevent multiple includes
Added some more comments to each node
Did some significant refactoring of partioVisualizer code, the previous vs current state is now kept in a PartioVizState struct and then current context vars are in a Context struct
Made some preprocessor defines for draw styles
Split up the compute function into smaller chunks as helper functions
Made slight modifications to the draw code, re-enabled always pointarray draw on DRAW_STYLE_POINT
Moved callbackID's into class variables