Open
Conversation
cmrd-senya
requested changes
Sep 28, 2017
| message = Message.new(jid, message_text).set_id(SecureRandom.uuid) | ||
| message.type = message_type | ||
| client.tap {|client| | ||
| client.send(message) unless client.nil? |
There was a problem hiding this comment.
I think that instead of explicitly setting the id we should use Jabber::Client#send_with_id method here, because it's better to rely on gem-provided methods when they are available.
Author
There was a problem hiding this comment.
send_with_id method does not generate a unique id
There was a problem hiding this comment.
It relies on IdGenerator.generate_id where the documentation literally says
Generate an unique ID.
If there is something wrong with uniqueness there, maybe you can consider to make a PR for the xmpp4r gem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
must be