Fix docker-entrypoint.sh loadmodule twice #504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #468
If redis container is started with a config file, the current
docker-entrypoint.shscript will still generate theredis-servercommand with--loadmoduleflag.If a
CONFIG REWRITEis issued (for example, by Sentinel client), theloadmoduleentries will be written to the config file. Restarting the container will then result in a module initialization error (due to modules being loaded twice).This PR add a check to skip
--loadmoduleflag if the container is started with a config file, and theloadmodule $moduleentry is already present.