-
Notifications
You must be signed in to change notification settings - Fork 254
feat: Register ansible and ansible-jinja languages for formatter
#1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @msivasubramaniaan, @datho7561, I'm sorry to annoy you by Your feedback would be greatly appreciated! Best wishes |
|
In order to get this working properly, we'll also need to register it on the language server side. I think we should fix this glob expression in vscode-yaml and the language server in order to avoid having to enumerate every language that's just a variation of yaml: https://github.com/redhat-developer/vscode-yaml/blob/main/src/extension.ts#L126 . (it should be |
datho7561
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Along with redhat-developer/yaml-language-server@67ecad2, this will fix the issue.
There are a few things I would prefer to be cleaned up in the PR before merging.
|
Hi @datho7561, Thanks! I have updated those content, please review again. I'm glad to fix problems you questioned. Besides, do I need to register similar languages to |
The new pattern I added should allow you to format if the files have .yaml or .yml as the extension. I can also add the ansible and ansible-jinja languages there if you think that's important (I think that most Ansible files use the .yaml extension though). |
|
@datho7561 I have removed release tag. My bad. |
datho7561
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Lanqing!
|
You're welcome! I truly appreciate your patient review. Lets looking forward to new release :) |
What does this PR do?
This PR adds activation event for
ansibleandansible-jinjalanguages.What issues does this PR fix or reference?
Is it tested? How?
manually
Thank you for review!
Regards