Skip to content

Conversation

@lqhuang
Copy link
Contributor

@lqhuang lqhuang commented Nov 17, 2025

What does this PR do?

This PR adds activation event for ansible and ansible-jinja languages.

What issues does this PR fix or reference?

Is it tested? How?

manually

Thank you for review!

Regards

@lqhuang
Copy link
Contributor Author

lqhuang commented Nov 27, 2025

Hi @msivasubramaniaan, @datho7561,

I'm sorry to annoy you by @ feature, would you please to review this PR?

Your feedback would be greatly appreciated!

Best wishes

@datho7561 datho7561 self-requested a review November 27, 2025 13:02
@datho7561
Copy link
Contributor

In order to get this working properly, we'll also need to register it on the language server side.

I think we should fix this glob expression in vscode-yaml and the language server in order to avoid having to enumerate every language that's just a variation of yaml: https://github.com/redhat-developer/vscode-yaml/blob/main/src/extension.ts#L126 . (it should be *.y?(a)ml from my understanding)

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with redhat-developer/yaml-language-server@67ecad2, this will fix the issue.

There are a few things I would prefer to be cleaned up in the PR before merging.

@lqhuang
Copy link
Contributor Author

lqhuang commented Nov 27, 2025

Hi @datho7561,

Thanks!

I have updated those content, please review again. I'm glad to fix problems you questioned.

Besides, do I need to register similar languages to redhat-developer/yaml-language-server repo? Or you could add these two lines easily in next commit?

@datho7561
Copy link
Contributor

Besides, do I need to register similar languages to redhat-developer/yaml-language-server repo? Or you could add these two lines easily in next commit?

The new pattern I added should allow you to format if the files have .yaml or .yml as the extension. I can also add the ansible and ansible-jinja languages there if you think that's important (I think that most Ansible files use the .yaml extension though).

@lqhuang
Copy link
Contributor Author

lqhuang commented Nov 28, 2025

@datho7561 I have removed release tag. My bad.

@lqhuang lqhuang requested a review from datho7561 November 28, 2025 02:53
@lqhuang lqhuang requested a review from datho7561 November 29, 2025 03:37
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lanqing!

@datho7561 datho7561 merged commit 2a4d165 into redhat-developer:main Dec 1, 2025
1 of 3 checks passed
@lqhuang lqhuang deleted the register-ansible branch December 1, 2025 14:36
@lqhuang
Copy link
Contributor Author

lqhuang commented Dec 1, 2025

You're welcome! I truly appreciate your patient review.

Lets looking forward to new release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants