-
Notifications
You must be signed in to change notification settings - Fork 90
[Konflux] isolate frontend and backend config schemas #2218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Konflux] isolate frontend and backend config schemas #2218
Conversation
Define frontend and backend config schemas in their respective plugins and remove konflux-common schema inheritance, so backend fields are marked backend/secret only. Fixes: Config schema visibility is both 'frontend' and 'secret' for konflux.clusters.*.serviceAccountToken.
Add changeset: "Separate Konflux frontend and backend config schemas to avoid visibility conflicts."
Changed Packages
|
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||



User description
Hey, I just made a Pull Request!
In a previous PR (#2212) we tried to fix the schema visibility issue, but the fix wasn't enough.
This PR completes the Konflux config split by moving the frontend schema into the konflux plugin and keeping backend/secret fields in konflux-backend. This "should" 🙏 prevent backend schema exports from inheriting frontend visibility and fixes the frontend/secret conflict during dynamic schema merge.
Error observed is same/similar with the one pointed out in the previous PR:
Config schema visibility is both 'frontend' and 'secret' for konflux.clusters.*.serviceAccountToken.Repro:
✔️ Checklist
PR Type
Bug fix, Enhancement
Description
Separate frontend and backend config schemas to resolve visibility conflicts
Move backend-only fields to konflux-backend plugin with proper visibility markers
Remove config schema from konflux-common to prevent inheritance issues
Add frontend config schema to main konflux plugin for UI-accessible fields
Diagram Walkthrough
File Walkthrough
config.d.ts
Add backend config schema with visibility markersworkspaces/konflux/plugins/konflux-backend/config.d.ts
@visibility backendmarkers to all backend configuration fieldsauthProvider,uiUrl,openshiftConsoleUrl,kubearchiveApiUrl,apiUrlserviceAccountTokenmarked as@visibility secretpackage.json
Remove config schema from common packageworkspaces/konflux/plugins/konflux-common/package.json
config.d.tsfrom files arrayconfigSchemafield from package.jsonpackage.json
Add config schema to frontend pluginworkspaces/konflux/plugins/konflux/package.json
config.d.tsto files arrayconfigSchemafield pointing toconfig.d.tsshaky-queens-sort.md
Add changeset for schema visibility fixworkspaces/konflux/.changeset/shaky-queens-sort.md