Skip to content

Conversation

@oskarjiang
Copy link

@oskarjiang oskarjiang commented Jan 23, 2026

Hey, I just made a Pull Request!

The example for customizing the support button doesn't work. From what I can find no such functionality exists in the <SupportButton/> component currently. Here's a suggestion for how it could be implemented.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Signed-off-by: Oskar Jiang <oskarjiang94@gmail.com>
@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Jan 23, 2026

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-global-header workspaces/global-header/plugins/global-header patch v1.20.1

Signed-off-by: Oskar Jiang <oskarjiang94@gmail.com>
@oskarjiang oskarjiang marked this pull request as ready for review January 23, 2026 22:13
@oskarjiang oskarjiang requested review from a team, ciiay and divyanshiGupta as code owners January 23, 2026 22:13
@christoph-jerolimov
Copy link
Member

Hi @oskarjiang. Thanks a lot for your contribution, we will take a look if this still matches our needs.

Can you add a screenshots of different use cases? Otherwise maybe @Eswaraiahsapram can create some with different use cases.

When this doesn't break the current configuration we could also take this as a patch.

Copy link
Member

@Eswaraiahsapram Eswaraiahsapram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oskarjiang , for your contribution. I think this should be a patch release rather than a minor one.

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@oskarjiang
Copy link
Author

Hi @oskarjiang. Thanks a lot for your contribution, we will take a look if this still matches our needs.

Can you add a screenshots of different use cases? Otherwise maybe @Eswaraiahsapram can create some with different use cases.

When this doesn't break the current configuration we could also take this as a patch.

My intention was to simply provide a fix for the use-case in your current example. So I think that one still suffices 😊

Also I believe that this change is backwards compatible as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants