-
Notifications
You must be signed in to change notification settings - Fork 34
[chore] Updating orchestrator npm packages to OCI artifacts #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[chore] Updating orchestrator npm packages to OCI artifacts #2231
Conversation
Signed-off-by: Leanne Ahern <lahern@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cherry-pick release-1.9 |
|
@rm3l: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
If we use quay refs here instead, you can't cherry pick because the plugins will be using different tags (1.9.0-- or 1.10.0--) and therefore also different digests. |
This option is supported as of RHDH 1.9 and allows inheriting the version from the dynamic-plugins.default.yaml (coming from the plugin catalog index image). This way, we are sure to use the default plugin version. NOTE: For this to work properly, the plugin refs should match. So if the orchestrator plugins refs are changed later to quay.io or registry.access.redhat.com in the DPDY, we should update them here as well.
Yeah, this is exactly the kind of issues I think the |
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Co-authored-by: OpinionatedHeron <OpinionatedHeron@users.noreply.github.com>
|
|
|



Description
Updating orchestrator npm packages to the relevant OCI Artifacts to reflect updates to RHDH.
npm packages were causing the scaffolder plugin to throw an error during startup
Which issue(s) does this PR fix or relate to
RHDHBUGS-2527
PR acceptance criteria
How to test changes / Special notes to the reviewer
Deploy Operator-based instance of RHDH with the orchestrator plugins enabled.