Skip to content

Conversation

@ljblancoredborder
Copy link
Member

Added a test for chefclient slice, because cgroup is not assigning a slice but it needs to be created

@the-label-bot the-label-bot bot added kind/bug kind/bug size/XS size/XS labels May 7, 2024
@the-label-bot
Copy link

the-label-bot bot commented May 7, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind bug 0.884 ✔️
Size M 0.904 ✔️

Copy link
Contributor

@malvads malvads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chef-client should not be assigned to a cgroup

Copy link
Contributor

@malvads malvads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check all the services with something like

def is_in_redborder_cgroup(service)
  slice = `systemctl show #{service} --property=Slice`.split('=')[1]
  slice.chomp! != 'system.slice'
end

for all excluded should return false and for memservices should return true

@the-label-bot the-label-bot bot added size/S size/S and removed size/XS size/XS labels May 9, 2024
@ljblancoredborder ljblancoredborder changed the title check memory is assigned to chefclient slice bugfix/#17186 check memory is assigned to chefclient slice Jun 24, 2024
@the-label-bot the-label-bot bot added size/M size/M and removed size/S size/S labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug kind/bug size/M size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants