Use the context of cluster_name in the function get_client_type_by_name#14723
Open
jilju wants to merge 1 commit intored-hat-storage:masterfrom
Open
Use the context of cluster_name in the function get_client_type_by_name#14723jilju wants to merge 1 commit intored-hat-storage:masterfrom
jilju wants to merge 1 commit intored-hat-storage:masterfrom
Conversation
Signed-off-by: Jilju Joy <jijoy@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jilju The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
Example of a situation which will be solved by this PR. get_client_type_by_name is calling is_hosted_cluster where it switch to provider context without considering the possibility of 2 provider clusters in the config, like in RDR scenarios. The info |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function get_client_type_by_name is unaware of the current cluster context. It assumes the current context is of the cluster_name value and call other functions which require provider mode context. Without current context being the given cluster, the called functions cannot use the value of ENV_DATA.provider_cluster_name.
Added switch to cluster_name context and marker switch_to_orig_index_at_last.