Fix test_rgw_kafka_notifications

[sagihirshfeld]

Changes made

1. Use a custom fork of the notify tool, where we drop the forced use of the old S3 signature. See my PR at the notify repo for details.

2. The use of Zookeeper in the setup is deprecated, and was updated elsewhere in Update AMQ Kafka deployment to latest Strimzi (KRaft, no ZooKeeper) #12966. This PR also updates the relevant part in test_rgw_kafka_notifications.

3. Make sure we run with a uniqe (random) topic name each run. This is mainly for quality of life when running multiple times locally for debugging.

Fixes: #13527

[sagihirshfeld]

/cherry-pick release-4.19

[openshift-cherrypick-robot]

@sagihirshfeld: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sagihirshfeld]

/cherry-pick release-4.18

[openshift-cherrypick-robot]

@sagihirshfeld: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sagihirshfeld]

/cherry-pick release-4.17

[openshift-cherrypick-robot]

@sagihirshfeld: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ocs-ci]

PR validation on existing cluster

Cluster Name: shirshfe-20vs11
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/workloads/app/amq/test_rgw_kafka_notifications.py::TestRGWAndKafkaNotifications::test_rgw_kafka_notifications
Additional Test Params: --skip-rpm-go-version-collection
OCP VERSION: 4.20
OCS VERSION: 4.20
tested against branch: master

Job PASSED.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PrasadDesala, sagihirshfeld, vkathole

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@sagihirshfeld: #13688 failed to apply on top of branch "release-4.17":

Applying: Use custom notify fork with support for region specifying
Using index info to reconstruct a base tree...
A	.secrets.baseline
M	ocs_ci/ocs/constants.py
M	tests/functional/workloads/app/amq/test_rgw_kafka_notifications.py
Falling back to patching base and 3-way merge...
Auto-merging tests/functional/workloads/app/amq/test_rgw_kafka_notifications.py
Auto-merging ocs_ci/ocs/constants.py
CONFLICT (modify/delete): .secrets.baseline deleted in HEAD and modified in Use custom notify fork with support for region specifying. Version Use custom notify fork with support for region specifying of .secrets.baseline left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Use custom notify fork with support for region specifying

Details

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@sagihirshfeld: #13688 failed to apply on top of branch "release-4.19":

Applying: Use custom notify fork with support for region specifying
Using index info to reconstruct a base tree...
A	.secrets.baseline
M	ocs_ci/ocs/constants.py
Falling back to patching base and 3-way merge...
Auto-merging ocs_ci/ocs/constants.py
CONFLICT (modify/delete): .secrets.baseline deleted in HEAD and modified in Use custom notify fork with support for region specifying. Version Use custom notify fork with support for region specifying of .secrets.baseline left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Use custom notify fork with support for region specifying

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@sagihirshfeld: #13688 failed to apply on top of branch "release-4.18":

Applying: Use custom notify fork with support for region specifying
Using index info to reconstruct a base tree...
A	.secrets.baseline
M	ocs_ci/ocs/constants.py
Falling back to patching base and 3-way merge...
Auto-merging ocs_ci/ocs/constants.py
CONFLICT (modify/delete): .secrets.baseline deleted in HEAD and modified in Use custom notify fork with support for region specifying. Version Use custom notify fork with support for region specifying of .secrets.baseline left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Use custom notify fork with support for region specifying

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.