Skip to content

fix: replication dropdown max height + minor css #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
debjyoti-pandit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: replication dropdown max height + minor css #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions locales/en/plugin__mcg-ms-console.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@
"Edit annotations": "Edit annotations",
"Delete {{resourceLabel}}": "Delete {{resourceLabel}}",
"Resource Page": "Resource Page",
"Filter policy by name": "Filter policy by name",
"Filter policy by label": "Filter policy by label",
"Filter by name": "Filter by name",
"Filter by label": "Filter by label",
"Create resource": "Create resource",
"Delete {{kind}}?": "Delete {{kind}}?",
"Are you sure you want to delete <2>{{resourceName}}</2> in namespace <6>{{namespace}}</6>?": "Are you sure you want to delete <2>{{resourceName}}</2> in namespace <6>{{namespace}}</6>?",
Expand Down
7 changes: 6 additions & 1 deletion packages/components/bucket-policy/bucket-policy.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
margin: var(--pf-global--spacer--lg) var(--pf-global--spacer--lg) 0
var(--pf-global--spacer--lg);
max-width: 75%;
padding-bottom: 20vh;
padding-bottom: 30vh;
}

&__form--margin-bottom {
Expand Down Expand Up @@ -45,3 +45,8 @@
.mcgms-breadcrumbs-header {
margin-top: var(--pf-global--spacer--md);
}

.pf-c-select__menu {
max-height: 30vh;
overflow-y: auto;
}
5 changes: 5 additions & 0 deletions packages/components/data-resource/data-resource.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
}

.nb-endpoints-form-entry {
padding-right: var(--pf-global--spacer--xl);
width: 100%;
}

Expand Down Expand Up @@ -71,6 +72,10 @@
overflow-y: auto;
}

.mcgms-resourceDropdown__container {
padding-right: var(--pf-global--spacer--xl);
}

.mcgms-disabledDropdown__container {
min-width: 20em;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/utils/list-page/list-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ export const GenericListPage: React.FC<GenericListPageProps> = ({
loaded={loaded}
onFilterChange={onFilterChange}
hideColumnManagement={true}
nameFilterPlaceholder={t('Filter policy by name')}
labelFilterPlaceholder={t('Filter policy by label')}
nameFilterPlaceholder={t('Filter by name')}
labelFilterPlaceholder={t('Filter by label')}
/>
</div>
<div className="create-resource__button">
Expand Down