Added nooba default bucket existence check#69
Added nooba default bucket existence check#69HaruChebrolu wants to merge 1 commit intored-hat-storage:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HaruChebrolu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@HaruChebrolu: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| cy.byLegacyTestID('horizontal-link-Buckets').click(); | ||
| cy.byTestRows('resource-row').each(($el) => { | ||
| cy.wrap($el).within(() => { | ||
| /* eslint-disable cypress/require-data-selectors */ |
There was a problem hiding this comment.
IMHO it would be better to add the appropriate data selector than disabling the lint rule.
|
@HaruChebrolu The Ci job failed with: |
| cy.byTestRows('resource-row').each(($el) => { | ||
| cy.wrap($el).within(() => { | ||
| /* eslint-disable cypress/require-data-selectors */ | ||
| cy.get('td') |
There was a problem hiding this comment.
please use cy.byTestRows. we have this tag already data-test-rows="resource-row"
3 participants
Added a check for nooba-default-bucket-class existence as a prerequisite to create a DataSource in Data Federation.