fix(#13): "Invalid objects" check fails with cross database calls#14
Open
toepoke wants to merge 1 commit intored-gate:masterfrom
Open
fix(#13): "Invalid objects" check fails with cross database calls#14toepoke wants to merge 1 commit intored-gate:masterfrom
toepoke wants to merge 1 commit intored-gate:masterfrom
Conversation
When querying the referenced database, checks that the invalid reference is in the same database where the test is being executed, otherwise the test will always fail if the reference is in another database on the same server. There may be a better fix for this dynamically inspect the results and see if the database name is the same?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When querying the referenced database, checks that the invalid reference is in the same database where the test is being executed, otherwise the test will always fail if the reference is in another database on the same server.
There may be a better fix for this dynamically inspect the results and see if the database name is the same?