Conversation
Collaborator
|
I'm not sure this is correct - my understanding is that only the SQP-1 variants should be using sqp-streaming. |
Replace GuideResources class with standalone load_* functions and a central build_template_specs() that processes radarr and sonarr together. Template IDs that collide across services are automatically disambiguated by prefixing with the service name via a Counter pass, eliminating the need to manually track or fix collisions. Also tightens allows_2160p() to allows_remux_2160p(), checking strictly for Remux-2160p rather than any quality containing "2160p". This corrects the SQP quality definition inference so streaming-only profiles (SQP-4, SQP-5) emit sqp-streaming instead of sqp-uhd. Fixes #172
SQP-4 and SQP-5 profiles do not include Remux-2160p, so sqp-streaming is the correct quality definition rather than sqp-uhd. Also regenerates all templates with the updated generator: instance names for cross-service collisions now use the service-prefixed form (e.g. radarr-anime-remux-1080p) and templates.json entry order is updated to match generator output. Fixes #172
rcdailey
force-pushed
the
fix/generator-sqp-quality-def-and-id-disambiguation
branch
from
1951022 to
460b082
Compare
Member
Author
|
I think I fixed it. I didn't like it, but the script just hard-codes against sqp-1 to determine the quality definition |
yammes08
approved these changes
Feb 23, 2026
yammes08
deleted the
fix/generator-sqp-quality-def-and-id-disambiguation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate-template.pyto process all services in a single pass, automatically detecting and prefixing cross-service template ID collisions with the service namesqp-streaming, all others usesqp-uhd(previously used an unreliableallows_2160pheuristic)Fixes #172
Supersedes the manual fixes in #170 and #171
cc @alex-matthews