Skip to content

Fix e2e test expectation due to new line info feature #7963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 3 commits into from
Apr 7, 2026
Merged

Fix e2e test expectation due to new line info feature #7963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aeb8595
Fix e2e expectation due to new line info feature
samsonasik Apr 7, 2026
6c78379
[ci-review] Rector Rectify
actions-user Apr 7, 2026
9e3bba8
ensure no merge conflict
samsonasik Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/cache-meta-extension/expected-output.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
1) src/DeadConstructor.php:2

---------- begin diff ----------
@@ @@
@@ Line 2 @@

final class DeadConstructor
{
Expand Down
2 changes: 1 addition & 1 deletion e2e/config-dist-fallback/expected-output.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
1) src/SomeClass.php:4

---------- begin diff ----------
@@ @@
@@ Line 4 @@

final class SomeClass
{
Expand Down
2 changes: 1 addition & 1 deletion e2e/config-file-priority/expected-output.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
1) src/SomeClass.php:4

---------- begin diff ----------
@@ @@
@@ Line 4 @@

final class SomeClass
{
Expand Down
3 changes: 2 additions & 1 deletion rules/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use PhpParser\Node\AttributeGroup;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Throw_;
use PhpParser\Node\Name;
use PhpParser\Node\Name\FullyQualified;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\Class_;
Expand Down Expand Up @@ -376,7 +377,7 @@ private function resolveClassMethodFromTraitUse(ClassLike $classLike, string $me
// early return for the class if it does not extend anything
private function shouldSkipNode(Class_ $class): bool
{
if ($class->extends !== null) {
if ($class->extends instanceof Name) {
return false;
}

Expand Down
Loading