fix: SafeDeclareStrictTypesRector

[calebdw]

Just replicating the failure for now---this seems to be a phpstan bug, the following is returning true when it should be returning false:

// given code that looks like this:

function skip_mixed_passed_to_round(array $data): float
{
    return round($data['value'], 2);
}

// $declaredType is a int|float---comes from round(int|float $num)
// $valueType is unknown `$data['value'] (implicit mixed) being passed to round()

private function isTypeSafeForStrictMode(Type $declaredType, Type $valueType): bool
{
    return $declaredType->accepts($valueType, strictTypes: true)
        ->yes();
}

This should be Maybe because the $valueType might not be a int|float, but instead phpstan is saying this is Yes

[calebdw]

@samsonasik, this should be good to go---after some digging I found that PHPStan is a very lenient with MixedType until higher levels and then it starts using StrictMixedType which does what you would expect. The solution is just to always use StrictMixedType

With these changes Rector safely updated ~1500 of my files and the pest and phpstan ci jobs passed

[calebdw]

@samsonasik, done 👍

[samsonasik]

Thank you @calebdw

[MrPunyapal]

@TomasVotruba @samsonasik, any chance it can be released soon?

[samsonasik]

@MrPunyapal you can try dev-main for now, it now excluded from sets as require more tests on real life project, see:

• fix: temporally disable SafeDeclareStrictTypesRector #7855

[MrPunyapal]

Thanks for update