[code-quality] Add NoSetupWithParentCallOverrideRector

[TomasVotruba]

In case of explicit parent::setUp() call, there is no need to add override attribute to the method. It was added by Rector core set, before it the rule got better at detecting useful cases.

This rule removes the override to make tests case more readable again 👍

[samsonasik]

If parent class is class in between, eg: extends AbstractFunctionalTestCase which has common setup for DB set, I think #[Override] still needed.

So only change when direct parent is a extends TestCase.

I will create PR for it.

[samsonasik]

Just check, it seems the TestsNodeAnalyzer::isInTestClass() check exactly extends equal name, so it seems not change the indirect parent class is class in between, so seems ok.

rector-phpunit/src/NodeAnalyzer/TestsNodeAnalyzer.php

Lines 30 to 44 in 9a2221b

	public function isInTestClass(Node $node): bool
	{
	$classReflection = $this->reflectionResolver->resolveClassReflection($node);
	if (! $classReflection instanceof ClassReflection) {
	return false;
	}
	foreach (PHPUnitClassName::TEST_CLASSES as $testCaseObjectClass) {
	if ($classReflection->is($testCaseObjectClass)) {
	return true;
	}
	}
	return false;
	}

[samsonasik]

Ok, I can reproduce indirect parent Test case, which still removed, which should be skipped:

I will create new PR for it.

[samsonasik]

I created PR:

• [CodeQuality] Skip indirect parent is PHPUnit\Framework\TestCase on NoSetupWithParentCallOverrideRector #618

for it.