module#2 (Mahmud)

[Mahmud-007]

added poison and if snake eats a poison game will restart

[MahdiMurshed]

basically addFood and addPoison does the same job .So we can make a reusable function like

const addObject= useCallback((type) => {
    let newObj= getRandomCell();
    while (isAllowedCell(newObj)) {
      newObj= getRandomCell();
    }
     if(type===CellType.Food){
     setFoods((currentFoods) => [...currentFoods, newObj]);
     }else{
     setPoisons(currentPoison=>[...currentPoison,newObj]);
  }
      
  }, [isAllowedCell]);

when calling

  useInterval(()=>addObject(CellType.Food), 3000);
  useInterval(()=>addObject(CellType.Poison), 3000);

[MahdiMurshed]

we can create a reusable removeObject(type) function like addObject

[owishiboo]

food and poison are basically the same but different types. We can check food or poison with the same function.

[owishiboo]

we can identify food or poison as an object, the only difference will be the type(the type of an object will be food or poison) and it will be less hassle to handle.

[owishiboo]

we don't need to send the setStates as they're already available in this function. It would be better to use cellType to decide which setState you want to call.

[Mahmud-007]

But this call the same addFood or addPoison function inside that. I wanted to generalize the adding and removing process for food and poison both.

[owishiboo]

yes, and we can easily do it by checking the type of the object.

removeObject(type){
if(type===CellType.Food)//do something for food
else if (type===CellType.Poison)//do something for poison
}

it is much simpler.
Also, you may consider food or poison as an object. The only thing that differs between them is the type. All the functionalities differ according to the type(for example, adding or removing is the same process for different arrays). We can easily use the type to differentiate.

[MahdiMurshed]

@owishiboo in your code you almost did the same thing . You passed array as an argument for checking types in findings function .