Module #3 (Tahsina Bintay Azam) by tahsina-azam · Pull Request #35 · recruit-org/snake

tahsina-azam · 2022-04-10T14:24:42Z

tried refactoring and tried to merge food and poison into the same state.

MahdiMurshed · 2022-04-12T03:50:21Z

src/hooks/snake.js


  useInterval(runSingleStep, 200);
-  useInterval(addFood, 3000);
+  useInterval(addObject("food"), 3000);


useInterval(()=>addObject("food"), 3000);

MahdiMurshed · 2022-04-12T03:50:56Z

src/hooks/snake.js

+  useInterval(addObject("food"), 3000);
  useInterval(removeFood, 100);
-  useInterval(addPoison, 15000);
+  useInterval(addObject("poison"), 15000);


useInterval(()=>addObject("poison"), 3000);

tahsina-azam · 2022-04-12T13:15:42Z

@MahdiMurshed thanks a lot, I did what you suggested and my code works just fine <3

MahdiMurshed · 2022-04-19T17:50:05Z

src/hooks/snake.js

+    setObjects([]);
+  }, []);
+
+  const isFood = useCallback(


isFood and isPoison are basicallly same.Can't we make one function to check both ? like

isObjectOfType(type)

Yes added that :) thanks for pointing it out <3

MahdiMurshed · 2022-04-19T17:52:05Z

src/hooks/snake.js

+  //suggested addObject method for food and poison ---------------->
+  const addObject = useCallback((type) => {
+    let newObject = getRandomCell(type);
+    while (isSnake(newObject) || isFood(newObject)) {


you missed isPoison()

MahdiMurshed · 2022-04-19T17:53:53Z

src/hooks/snake.js

+    // }
+  }, []);
+  //removeObject method for removing food or poison-------------->
+  const removeObject = useCallback((type) => {


we are deleting objects whose age are greater than 10 sec .So why do we need to check object type while deleting any object?

yes, you were right, for some reason that part of the code was causing the problem, I thought I should have the control over when I wanted to remove my poison cell that's why I was checking object Type. Thanks btw.

owishiboo · 2022-04-19T18:00:30Z

src/hooks/snake.js

-      setFoods((currentFoods) =>
-        currentFoods.filter((food) => Date.now() - food.createdAt <= 10 * 1000)
+      setObjects((currentFoods) =>
+        currentFoods.filter(


we're removing an element whether it is food or poison for the same time-lapse. We don't need to check the type here.

yes, I totally agree. For some reason that part of the code was causing the problem, I thought I should have the control over when I wanted to remove my poison cell that's why I was checking object Type. Thanks btw.

owishiboo · 2022-04-19T18:03:19Z

src/hooks/snake.js

+      setObjects((currentFoods) =>
+        currentFoods.filter(
+          (food) =>
+            Date.now() - food.createdAt <= 10 * 1000 && food.type === "food"


We can use the CellType here instead of the string.
food.type===CellType.Food

MahdiMurshed · 2022-04-19T18:24:16Z

src/hooks/snake.js

+  useInterval(() => addObject("food"), 3000);
+  useInterval(() => removeObject("food"), 100);
+  useInterval(() => addObject("poison"), 15000);
+  useInterval(() => removeObject("poison"), 100);


we dont need to call removeObject twice and removeObject doesn't need to take any parameter

MahdiMurshed · 2022-04-19T18:27:04Z

src/hooks/snake.js

+  useInterval(runSingleStep, 200);
+  useInterval(() => addObject("food"), 3000);
+  useInterval(() => removeObject("food"), 100);
+  useInterval(() => addObject("poison"), 15000);


You are not taking the advantage of CellType object .By hard coding "food" you are creating a source of bug . Do It instead

addObject(CellType.Food) removeObject(CellType.Poison)

@owishiboo and @MahdiMurshed used the cell type 👍

MahdiMurshed · 2022-04-19T19:04:59Z

src/hooks/snake.js

+  useInterval(() => addObject(CellType.Food), 3000);
+  useInterval(() => removeObject(CellType.Food), 100);
+  useInterval(() => addObject(CellType.Poison), 15000);
+  useInterval(() => removeObject(CellType.Poison), 100);


Sorry,removeFood doesn't need any parameter, my bad.And why calling twice the same function at same time interval? you are not removing the object depending on types .You are removing objects whose age is greater than 10 sec regardless of the type.

useInterval(() => addObject(CellType.Food), 3000); useInterval(() => addObject(CellType.Poison), 15000); useInterval(removeObject, 100);

dang , missed that part :")

MahdiMurshed · 2022-04-19T19:11:48Z

src/hooks/snake.js

+      isSnake(newObject) ||
+      isObjectOfType(newObject, CellType.Food) ||
+      isObjectOfType(newObject, CellType.Poison)
+    ) {


as you previously forgot to add isPoison() in while condition, There is a possibility that you will forget it again. So why not create a separate function named isObject whose job is to check whether the given coordinate is a food or poison .

tahsina-azam added 7 commits March 11, 2022 10:19

Snake Code

f88dc0e

added timing condition to foods

7a1921c

finished module-1

e54230a

added a food that will kill the snake

3dbb675

done with refactoring the code and used a new hook useMemo

ef72127

removed some unnecessary stuffs

c3604fe

too many rerenders

87f279a

tahsina-azam mentioned this pull request Apr 11, 2022

Module #2 (Tahsina Bintay Azam) #31

Open

addObject method problem

c7ede61

MahdiMurshed reviewed Apr 12, 2022

View reviewed changes

tahsina-azam added 3 commits April 12, 2022 19:19

solved addObject bug

1f433f3

added common function for removing food/poison

942fd56

tried to merge food and poison in one state

a8a4be2

MahdiMurshed reviewed Apr 19, 2022

View reviewed changes

owishiboo reviewed Apr 19, 2022

View reviewed changes

successfuly converted food and poison into one state

d92514f

MahdiMurshed reviewed Apr 19, 2022

View reviewed changes

added a new method isObjectOfType to check object type

97f7e5c

MahdiMurshed reviewed Apr 19, 2022

View reviewed changes

removed unnecessary parameter from removeObject

3cc56f3

Conversation

tahsina-azam commented Apr 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MahdiMurshed Apr 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tahsina-azam commented Apr 12, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tahsina-azam commented Apr 10, 2022 •

edited

Loading

MahdiMurshed Apr 12, 2022 •

edited

Loading