Skip to content

Test#1666

Merged
arpitgupta1214 merged 2 commits intomainfrom
test
Apr 10, 2026
Merged

Test#1666
arpitgupta1214 merged 2 commits intomainfrom
test

Conversation

@arpitgupta1214
Copy link
Copy Markdown
Collaborator

@arpitgupta1214 arpitgupta1214 commented Apr 10, 2026

Summary by cubic

Removed dead artist detail read code and switched the tasks list to use owner_email from the tasks API. This reduces network calls and simplifies the tasks page.

  • Refactors
    • Deleted unused artist routes and hooks: app/api/artist/route.tsx, hooks/useArtistInstruction.ts, hooks/useArtistKnowledge.ts, lib/getArtist.tsx.
    • TasksList now reads owner_email directly from Task; removed React Query batch email fetch.
    • Extended Task type with owner_email; minor getTasks formatting update.
    • Removed stale query invalidation in useSaveKnowledgeEdit tied to deleted queries.

Written for commit 5a4fe8e. Summary will update on new commits.

Summary by CodeRabbit

  • Refactor
    • Streamlined task data fetching by including owner email information directly in task records.
    • Simplified backend data retrieval mechanisms for improved performance.

* chore: remove dead artist detail read code

* chore: remove dead local artist detail route
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
recoup-chat Building Building Preview Apr 10, 2026 2:10am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ef97dfe6-782a-42b9-9c63-a1bf86d90ef9

📥 Commits

Reviewing files that changed from the base of the PR and between a16ac72 and 5a4fe8e.

📒 Files selected for processing (7)
  • app/api/artist/route.tsx
  • components/TasksPage/TasksList.tsx
  • hooks/useArtistInstruction.ts
  • hooks/useArtistKnowledge.ts
  • hooks/useSaveKnowledgeEdit.ts
  • lib/getArtist.tsx
  • lib/tasks/getTasks.ts

📝 Walkthrough

Walkthrough

This PR removes unused artist detail infrastructure—including an API route handler, utility functions, and React Query hooks—and simplifies task email handling by using task.owner_email directly instead of batch fetching. It also removes associated cache invalidation logic.

Changes

Cohort / File(s) Summary
Removed artist detail infrastructure
app/api/artist/route.tsx, lib/getArtist.tsx, hooks/useArtistInstruction.ts, hooks/useArtistKnowledge.ts
Deleted API route handler for fetching artist data, utility function, and React Query hooks that queried artist instructions and knowledge from the removed endpoint.
Simplified email fetching
components/TasksPage/TasksList.tsx, hooks/useSaveKnowledgeEdit.ts
Removed batch email lookup logic in TasksList; now reads task.owner_email directly. Also removed React Query cache invalidation for artist queries in the save knowledge hook.
Extended Task type
lib/tasks/getTasks.ts
Added optional owner_email?: string | null property to the Task type to support direct task ownership email data.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • sweetmantech
  • cubic-dev-ai

Poem

✨ Dead code swept away, like dust in the wind,
Artist queries gone—no longer pinned.
Email flows simpler, task owns its truth,
Cleaner architecture for developer's youth. 🧹

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arpitgupta1214 arpitgupta1214 merged commit b5ddb94 into main Apr 10, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant