Skip to content

revert: artist detail read endpoint#417

Merged
arpitgupta1214 merged 1 commit intotestfrom
codex/revert-artist-read-api
Apr 9, 2026
Merged

revert: artist detail read endpoint#417
arpitgupta1214 merged 1 commit intotestfrom
codex/revert-artist-read-api

Conversation

@arpitgupta1214
Copy link
Copy Markdown
Collaborator

@arpitgupta1214 arpitgupta1214 commented Apr 9, 2026

Reverts the merged artist detail read slice from #416.

This undo PR removes:

  • GET /api/artists/{id}
  • artist detail validator/handler/helper/tests
  • the dedicated Supabase detail read helper

Reason:

  • there is no live in-app consumer for the single-artist detail endpoint in chat yet
  • the corresponding chat change is being closed instead of carried forward

This keeps the repos aligned until a real consumer is ready.


Summary by cubic

Reverts the artist detail read API to remove an unused endpoint and keep repos aligned. Removes GET /api/artists/[id] along with its handler, request validation, Supabase selector, and tests until chat has a real consumer.

Written for commit 91f126a. Summary will update on new commits.

Summary by CodeRabbit

  • Removed Features
    • Removed the API endpoint for retrieving individual artist details.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
recoup-api Ready Ready Preview Apr 9, 2026 0:09am

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c6eadc04-be48-4990-966f-b459ebb98eb6

📥 Commits

Reviewing files that changed from the base of the PR and between 7705373 and 91f126a.

⛔ Files ignored due to path filters (2)
  • lib/artists/__tests__/getArtistHandler.test.ts is excluded by !**/*.test.*, !**/__tests__/** and included by lib/**
  • lib/artists/__tests__/validateGetArtistRequest.test.ts is excluded by !**/*.test.*, !**/__tests__/** and included by lib/**
📒 Files selected for processing (5)
  • app/api/artists/[id]/route.ts
  • lib/artists/getArtistById.ts
  • lib/artists/getArtistHandler.ts
  • lib/artists/validateGetArtistRequest.ts
  • lib/supabase/accounts/selectAccountWithArtistDetails.ts
💤 Files with no reviewable changes (5)
  • app/api/artists/[id]/route.ts
  • lib/supabase/accounts/selectAccountWithArtistDetails.ts
  • lib/artists/getArtistHandler.ts
  • lib/artists/validateGetArtistRequest.ts
  • lib/artists/getArtistById.ts

📝 Walkthrough

Walkthrough

This pull request removes the entire GET /api/artists/{id} endpoint and its supporting infrastructure, including route handlers, request validation, artist data fetching functions, and database query operations. No replacement functionality is provided.

Changes

Cohort / File(s) Summary
Route Handler
app/api/artists/[id]/route.ts
Removed OPTIONS preflight and GET request handlers for the single artist endpoint.
Request Handling & Validation
lib/artists/getArtistHandler.ts, lib/artists/validateGetArtistRequest.ts
Removed request handler that delegated to validation and data fetching, along with validation logic for artist access control and authentication.
Data Fetching
lib/artists/getArtistById.ts, lib/supabase/accounts/selectAccountWithArtistDetails.ts
Removed artist data retrieval function and its underlying Supabase query that fetched account details with artist information including socials and metadata.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • sweetmantech

Poem

🗑️ The artist's door has closed today,
Five files now fade away,
A clean removal, swift and neat,
Where once the endpoints beat. 🎨

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Solid & Clean Code ✅ Passed Revert pull request demonstrates excellent SOLID and Clean Code adherence with complete removal of five files and zero orphaned references.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/revert-artist-read-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arpitgupta1214 arpitgupta1214 merged commit a6f64ab into test Apr 9, 2026
5 of 6 checks passed
arpitgupta1214 added a commit that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants