-
Notifications
You must be signed in to change notification settings - Fork 6
fix: add system prompt to save Spotify URL to artist socials #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sweetmantech
merged 4 commits into
test
from
sweetmantech/myc-3985-spotify-deep-research-artist-socials-not-filling-in-artist
Jan 21, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
93c9518
fix: add system prompt to save Spotify URL to artist socials
sweetmantech 4d4ec66
debug: add logging to updateArtistSocials to trace empty response
sweetmantech 0038cc4
fix: normalize profile URLs to match database format
sweetmantech 67836d4
chore: remove debug logging from updateArtistSocials
sweetmantech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { describe, it, expect } from "vitest"; | ||
| import { normalizeProfileUrl } from "../normalizeProfileUrl"; | ||
|
|
||
| describe("normalizeProfileUrl", () => { | ||
| it("removes https:// protocol from URL", () => { | ||
| expect(normalizeProfileUrl("https://open.spotify.com/artist/123")).toBe( | ||
| "open.spotify.com/artist/123", | ||
| ); | ||
| }); | ||
|
|
||
| it("removes http:// protocol from URL", () => { | ||
| expect(normalizeProfileUrl("http://twitter.com/user")).toBe("twitter.com/user"); | ||
| }); | ||
|
|
||
| it("returns URL unchanged if no protocol", () => { | ||
| expect(normalizeProfileUrl("open.spotify.com/artist/123")).toBe( | ||
| "open.spotify.com/artist/123", | ||
| ); | ||
| }); | ||
|
|
||
| it("handles empty string", () => { | ||
| expect(normalizeProfileUrl("")).toBe(""); | ||
| }); | ||
|
|
||
| it("handles null/undefined", () => { | ||
| expect(normalizeProfileUrl(null as unknown as string)).toBe(""); | ||
| expect(normalizeProfileUrl(undefined as unknown as string)).toBe(""); | ||
| }); | ||
|
|
||
| it("removes trailing slash", () => { | ||
| expect(normalizeProfileUrl("https://instagram.com/user/")).toBe( | ||
| "instagram.com/user", | ||
| ); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| /** | ||
| * Normalizes a profile URL by removing the protocol and trailing slash. | ||
| * This ensures consistent URL format for database queries and storage. | ||
| * | ||
| * @param url - The profile URL to normalize | ||
| * @returns The normalized URL without protocol or trailing slash | ||
| */ | ||
| export function normalizeProfileUrl(url: string | null | undefined): string { | ||
| if (!url) return ""; | ||
|
|
||
| return url | ||
| .replace(/^https?:\/\//, "") | ||
| .replace(/\/$/, ""); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.