fix: create room if roomId is provided but doesn't exist#136
Merged
sweetmantech merged 1 commit intotestfrom Jan 19, 2026
Conversation
When a roomId is provided to setupConversation but the room doesn't actually exist in the database, we now check and create it instead of failing with a foreign key constraint error on the memories table. This fixes the error: Error creating memory: Key (room_id)=(...) is not present in table "rooms" Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roomIdis provided tosetupConversationbut the room doesn't actually exist in the databaseroomIdis provided, and creates it if neededProblem
The error occurred because:
roomIdthat doesn't exist in the databasesetupConversationassumed ifroomIdis provided, the room existsKey (room_id)=(...) is not present in table "rooms"Test plan
🤖 Generated with Claude Code