Add support for AGP 9 #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a convenience compat class that supports backwards compatibility as well as support for LibraryExtension, which will he required with AGP9. Upgrading to AGP 9 will also require extension developers to replace BaseExtension in the `Project.android` declaration with LibraryExtension, and also replace `compileSdkVersion` with `compileSdk` outside of `defaultConfig`, as well as move `targetSdk` to a new lint block, and remove `apply(plugin = "kotlin-android")` since AGP 9 has built-in Kotlin, that is no longer supported. This should have no affecf for those that don't upgrade to AGP 9, or those you don't decide to use LibraryExtension in AGP 8 which is also supported.
Contributor
Author
|
Note: this also depends on #8 since AGP 9 requires Gradle 9 |
Contributor
Author
|
Also kinda depends on #9 as it was built on top of that one. So no guarantee it works without that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a convenience compat class that supports backwards compatibility as well as support for LibraryExtension, which will he required with AGP9.
Upgrading to AGP 9 will also require extension developers to replace BaseExtension in the
Project.androiddeclaration with LibraryExtension, and also replacecompileSdkVersionwithcompileSdkoutside ofdefaultConfig, as well as movetargetSdkto a new lint block, and removeapply(plugin = "kotlin-android")since AGP 9 has built-in Kotlin, that is no longer supported.This should have no affecf for those that don't upgrade to AGP 9, or those you don't decide to use LibraryExtension in AGP 8 which is also supported.