Skip to content

Fix piano plugin resolution by using HTTPS Git URL#145

Closed
ystknsh wants to merge 1 commit intomainfrom
chore/lockfile-update
Closed

Fix piano plugin resolution by using HTTPS Git URL#145
ystknsh wants to merge 1 commit intomainfrom
chore/lockfile-update

Conversation

@ystknsh
Copy link
Copy Markdown
Contributor

@ystknsh ystknsh commented Mar 23, 2026

概要

  • @gui-chat-plugin/piano の参照形式を github:receptron/GUIChatPluginPiano から https://github.com/receptron/GUIChatPluginPiano.git に変更
  • yarn.lock の resolved URL を同期

背景

  • yarn v1 の github: 記法では、キャッシュのハッシュ不一致やパッケージ解決の問題が発生し、dist/ が含まれない状態でインストールされることがあった
  • HTTPS Git URL 形式に変更することで解決

エラー内容

[plugin:vite:import-analysis] Failed to resolve import "@gui-chat-plugin/piano/vue" from "src/tools/index.ts". Does the file exist?
/Users/yasutaka/Documents/mac-workspace/mulmo/MulmoChat/src/tools/index.ts:42:24
30 |  import ScrollToAnchorPlugin from "@gui-chat-plugin/scroll-to-anchor/vue";
31 |  import MindMapPlugin from "@gui-chat-plugin/mindmap/vue";
32 |  import PianoPlugin from "@gui-chat-plugin/piano/vue";
   |                           ^
33 |  import DrawingGamePlugin from "@gui-chat-plugin/drawing-game/vue";
34 |  import AkinatorPlugin from "guichat-plugin-akinator/vue";
    at TransformPluginContext._formatLog (file:///Users/yasutaka/Documents/mac-workspace/mulmo/MulmoChat/node_modules/vite/dist/node/chunks/config.js:28999:43)
    at TransformPluginContext.error (file:///Users/yasutaka/Documents/mac-workspace/mulmo/MulmoChat/node_modules/vite/dist/node/chunks/config.js:28996:14)
    at normalizeUrl (file:///Users/yasutaka/Documents/mac-workspace/mulmo/MulmoChat/node_modules/vite/dist/node/chunks/config.js:27119:18)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async file:///Users/yasutaka/Documents/mac-workspace/mulmo/MulmoChat/node_modules/vite/dist/node/chunks/config.js:27177:32
    at async Promise.all (index 31)
    at async TransformPluginContext.transform (file:///Users/yasutaka/Documents/mac-workspace/mulmo/MulmoChat/node_modules/vite/dist/node/chunks/config.js:27145:4)
    at async EnvironmentPluginContainer.transform (file:///Users/yasutaka/Documents/mac-workspace/mulmo/MulmoChat/node_modules/vite/dist/node/chunks/config.js:28797:14)
    at async loadAndTransform (file:///Users/yasutaka/Documents/mac-workspace/mulmo/MulmoChat/node_modules/vite/dist/node/chunks/config.js:22670:26)

変更範囲

  • package.json: piano プラグインの参照 URL 変更
  • yarn.lock: 参照形式の変更に伴う更新

アプリケーションへの影響

  • ロジック変更なし
  • UI/API の動作変更なし

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated dependency configuration for package management.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 23, 2026

📝 Walkthrough

Walkthrough

Updated the @gui-chat-plugin/piano dependency reference in package.json from GitHub shorthand notation to an explicit HTTPS Git URL format. No functional changes or configuration modifications were applied.

Changes

Cohort / File(s) Summary
Dependency Reference Format
package.json
Changed @gui-chat-plugin/piano dependency from GitHub shorthand (github:receptron/GUIChatPluginPiano) to HTTPS Git URL (https://github.com/receptron/GUIChatPluginPiano.git).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A URL once hidden in shorthand's disguise,
Now blooms in full form before our rabbit eyes,
HTTPS clarity, no mystery left to solve,
A small change to help dependencies resolve! 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix piano plugin resolution by using HTTPS Git URL' directly and clearly summarizes the main change: updating the piano plugin dependency reference from GitHub shorthand to an HTTPS Git URL to fix resolution issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/lockfile-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ystknsh ystknsh changed the title chore: update package dependencies lockfiles Fix piano plugin resolution by using HTTPS Git URL Mar 23, 2026
@ystknsh ystknsh marked this pull request as ready for review March 23, 2026 06:45
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
package.json (1)

60-60: Dependency is already pinned in yarn.lock, but consider making it explicit in package.json for clarity.

While the bare .git URL in package.json is loose, the dependency is already resolved to a specific commit (166821d095217f7c788ce600048e5cd688751240) in yarn.lock, ensuring reproducible installs. However, pinning explicitly in package.json (e.g., "@gui-chat-plugin/piano": "https://github.com/receptron/GUIChatPluginPiano.git#166821d095217f7c788ce600048e5cd688751240") would make the intent clearer and reduce reliance on lock file interpretation.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 60, The package entry for "@gui-chat-plugin/piano" in
package.json currently uses a bare Git URL; update that dependency to pin to the
exact commit referenced in yarn.lock by appending the commit SHA
(166821d095217f7c788ce600048e5cd688751240) to the URL (i.e., use the Git URL
with "#<commit>") so package.json explicitly matches the resolved version and
ensures clearer, reproducible installs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@package.json`:
- Line 60: The package entry for "@gui-chat-plugin/piano" in package.json
currently uses a bare Git URL; update that dependency to pin to the exact commit
referenced in yarn.lock by appending the commit SHA
(166821d095217f7c788ce600048e5cd688751240) to the URL (i.e., use the Git URL
with "#<commit>") so package.json explicitly matches the resolved version and
ensures clearer, reproducible installs.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8b9a3494-5096-494a-a47b-0b9eb38f8d1d

📥 Commits

Reviewing files that changed from the base of the PR and between 4965871 and 6bbe98f.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json

@ystknsh
Copy link
Copy Markdown
Contributor Author

ystknsh commented Mar 23, 2026

こちらは不要な PR でした。
手元で yarn cache clean でキャッシュを消せば良い話でした。

@ystknsh ystknsh closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant