Fix coverage parsing for projects that use namespaces#337
Open
DaDummy wants to merge 3 commits intorecca0120:mainfrom
Open
Fix coverage parsing for projects that use namespaces#337DaDummy wants to merge 3 commits intorecca0120:mainfrom
DaDummy wants to merge 3 commits intorecca0120:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
- Coverage 95.52% 95.42% -0.11%
==========================================
Files 60 60
Lines 4516 4520 +4
Branches 1012 1012
==========================================
- Hits 4314 4313 -1
- Misses 197 203 +6
+ Partials 5 4 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4e8d671 to
9a327a4
Compare
Author
|
The observed issue and new code should now be covered in the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In projects with more than one namespace the coverage was not correctly parsed.
Having multiple namespaces resulted in the following hierarchy being output by the XMLParser:
{ "node": { "?xml": { "@_version": "1.0", "@_encoding": "UTF-8" }, "coverage": { "project": { "package": [ { "file": { /* ... */ } }, { "file": [ { /* ... */ } ] } ] } } } }This was not correctly handled by
querySelectorAll, which assumed that only the innermost selected node could be an array.This MR corrects that.