Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds configuration options for code coverage functionality, allowing users to customize the output path and file name. The changes update the Configuration interface to support generic types and introduce two new configuration settings for coverage customization.
- Updated Configuration interface to use generic type parameters for better type safety
- Added two new configuration settings:
phpunit.coveragePathandphpunit.coverageFile - Modified Xdebug class to use configurable coverage directory and file names instead of hardcoded values
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/PHPUnit/Configuration.ts | Updated interface and implementation to support generic types for configuration values |
| src/PHPUnit/CommandBuilder/Xdebug.ts | Modified to use configurable coverage path and file name settings |
| package.json | Added new configuration properties for coverage path and file customization |
| README.md | Added documentation for the new coverage configuration options |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add code coverage configuration to customize the path and the file name.