Skip to content

chore: fix project build and setup GitHub Actions#32

Open
thatfiredev wants to merge 1 commit intorealdm:masterfrom
thatfiredev:rpf/setup-github-actions
Open

chore: fix project build and setup GitHub Actions#32
thatfiredev wants to merge 1 commit intorealdm:masterfrom
thatfiredev:rpf/setup-github-actions

Conversation

@thatfiredev
Copy link
Contributor

@thatfiredev thatfiredev commented Jun 7, 2020

This PR should setup GitHub Actions on the project and fix some build errors:

  • match compileSdkVersion and targetSdkVersion
  • fix type inference errors on ui's C2BPaymentFragment.kt
  • use AndroidX's CardView instead of the Support Library
  • make non-null asserted call to classLoader

Also notice that when building Pull Requests, GitHub Actions will call gradlew assembleDebug testDebugUnitTest which is much faster and catches obvious bugs.

Copy link
Owner

@realdm realdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
Please squash your commits before your merge.

@thatfiredev thatfiredev force-pushed the rpf/setup-github-actions branch from 338e6c2 to 98f8338 Compare June 15, 2020 12:48
@thatfiredev
Copy link
Contributor Author

@realdm I've squashed the commits. I don't have write permissions on this repo, you'll have to merge it.
You might also need to enable Github Actions on the repo settings after merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants