Skip to content

Conversation

@mickael-menu
Copy link
Member

Deprecated

Streamer

  • Removed title inference based on folder names within image and audio archives. Use the archive's filename instead.

This title inference was not a well-known or common convention in the comic book archive community.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the title inference feature that attempted to derive publication titles from folder names within image and audio archives. This was not a well-known convention in the comic book archive community, so the functionality is being deprecated in favor of using the archive's filename for title fallback.

Changes:

  • Removed the guessTitle() method from the Container extension
  • Updated ImageParser and AudioParser to no longer infer titles from folder structure
  • Modified LibraryService to use the archive filename (without extension) as the title fallback

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Tests/StreamerTests/Toolkit/Extensions/ContainerTests.swift Deleted test file for the removed guessTitle() functionality
Sources/Streamer/Toolkit/Extensions/Container.swift Removed the guessTitle() method that inferred titles from folder names
Sources/Streamer/Parser/Image/ImageParser.swift Removed fallbackTitle parameter and usage, now relies on metadata or nil
Sources/Streamer/Parser/Audio/AudioParser.swift Changed to pass nil for title instead of calling guessTitle()
TestApp/Sources/Library/LibraryService.swift Updated to use archive filename as title fallback and pass title explicitly to helper methods
CHANGELOG.md Documented the deprecation of folder-based title inference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mickael-menu mickael-menu merged commit 4a4b7f9 into develop Jan 20, 2026
5 of 6 checks passed
@mickael-menu mickael-menu deleted the remove-title-fallback branch January 20, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants