fix(header): improve navbar scroll behavior outside hero section#1668
fix(header): improve navbar scroll behavior outside hero section#1668harishsehlangia wants to merge 3 commits intoreactplay:mainfrom
Conversation
👷 Deploy request for reactplayio pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
1dcddee to
04e2b84
Compare
|
This PR is closed due to one edge case that is not covered in this PR. I'll solve that and will raise a new PR. |
Description
The navbar should remain visible while the user is inside the hero section.
After crossing the hero section, the navbar visibility should depend on scroll direction:
This improves user experience and prevents sudden header disappearance at the top of the page.
Fixes #1665
Type of change
How Has This Been Tested?
Checklist:
Screenshots or example output