Finalize library for v0.31 #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix throwing an error while trying to access `CanvasApi.metrics` members before the `Canvas` is fully mounted;
* Fix `DropOnCanvas` to allow drop non-entity elements, get rid of jarring element move on drop;
* Allow to configure or disable annotation support from `DefaultWorkspace` and `ClassicWorkspace` via `annotations` prop;
* Move `renameLink` command from `VisualAuthoringCommands` to `AnnotationCommands`, deprecate original command;
* Always provide UI support for `renameLink` command from `AnnotationCommands` even if `VisualAuthoring` is not used;
* Export `AnnotationSupport`, `AnnotationTopic` and `SelectionActionAnnotate` from the main entry point;
* Deprecate `WorkpaceContext.{group, ungroupAll, ungroupSome}` methods in favor of free functions `groupEntities()`, `ungroupAllEntities()`, `ungroupSomeEntities()`.
* Fix missing or incorrect JSDoc;
* Add JSDoc for `VisualAuthoringCommands`, remove unnecessary parameters `source` and `targetIsNew` from `findOrCreateEntity` command;
* Add GitHub Action workflow to publish the library on the NPM;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CanvasApi.metricsmembers before theCanvasis fully mounted;DropOnCanvasto allow drop non-entity elements, get rid of jarring element move on drop;DefaultWorkspaceandClassicWorkspaceviaannotationsprop;renameLinkcommand fromVisualAuthoringCommandstoAnnotationCommands, deprecate original command;renameLinkcommand fromAnnotationCommandseven ifVisualAuthoringis not used;AnnotationSupport,AnnotationTopicandSelectionActionAnnotatefrom the main entry point;WorkpaceContext.{group, ungroupAll, ungroupSome}methods in favor of free functionsgroupEntities(),ungroupAllEntities(),ungroupSomeEntities().VisualAuthoringCommands, remove unnecessary parameterssourceandtargetIsNewfromfindOrCreateEntitycommand;