Fixed broken links in Hindi JSX documentation #322
Conversation
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Thank you for creating a pull request for this.
I have added a change request for a minor change once those are done we can get this merged.
| ``` | ||
| इस खाली टैग को *[React fragment](TODO)* कहा जाता है। React fragments आपको ब्राउज़र HTML ट्री में कोई निशान छोड़े बिना चीजों को ग्रुप करने देते हैं। | ||
| इस खाली टैग को *[React fragment](https://react.dev/reference/react/Fragment)* कहा जाता है। React fragments आपको ब्राउज़र HTML ट्री में कोई निशान छोड़े बिना चीजों को ग्रुप करने देते हैं। |
There was a problem hiding this comment.
can you update the link similar to we have in english version of the doc? https://github.com/reactjs/react.dev/blob/main/src/content/learn/writing-markup-with-jsx.md?plain=1#L172
| ``` | ||
| आप [इन सभी ऐट्रिब्यूट्स को React DOM एलिमेंट्स में पा सकते हैं](TODO). यदि आप एक गलत पाते हैं, तो चिंता न करें React संभावित सुधार के साथ एक संदेश [ब्राउज़र कंसोल](https://developer.mozilla.org/docs/Tools/Browser_Console) पर प्रिंट करेगी। | ||
| आप [इन सभी ऐट्रिब्यूट्स को React DOM एलिमेंट्स में पा सकते हैं](https://react.dev/reference/react-dom/components/common). यदि आप एक गलत पाते हैं, तो चिंता न करें React संभावित सुधार के साथ एक संदेश [ब्राउज़र कंसोल](https://developer.mozilla.org/docs/Tools/Browser_Console) पर प्रिंट करेगी। |
There was a problem hiding this comment.
same for here, update the link similar to english version https://github.com/reactjs/react.dev/blob/main/src/content/learn/writing-markup-with-jsx.md?plain=1#L217
There was a problem hiding this comment.
Thank you for pointing this out! 🙌
Updated links to use relative URLs as in the English documentation. #323
I have updated the links to use relative URLs as per your suggestion. Let me know if there's anything else that needs to be adjusted. 😊
|
You could have just pushed a new commit to this PR itself in place of creating a new pull request. Anyways I will close this pull request. |
|
Thank you, @arshadkazmi42. I am currently in the learning phase, so by mistake, a new pull request was created. I will make sure to be more careful next time. Again, thank you for merging my pull request. 😊 |
|
@mohan-marwari OpenSource community is really good and people are there for helping new contributors. You can always ask for help. I have been to the stage you are at and have received really good help and guidance during my early contributions. Also feel free to check open issues of the repository, we have some translation work pending and those are always good place to start for opensource journey. |
|
Ok Sir 👍 |
2 participants
Fixed broken links in Hindi JSX documentation
I have updated two broken links in the Hindi JSX documentation that were pointing to placeholder URLs (
TODO). The changes are as follows:React Fragment Link:
React DOM Attributes Link:
These fixes ensure that users are directed to the correct pages for additional information.
Let me know if further changes are required. Thank you! 😊