Skip to content

Conversation

@didley
Copy link
Contributor

@didley didley commented Nov 27, 2024

Fixes #590

There was a breaking change introduced here that didn't allow the picker to set to nullish values on Android.

I've tested this change locally and it solves the issue

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Naturalclar Naturalclar merged commit 492e4ce into react-native-picker:master Dec 3, 2024
6 of 12 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
## [2.10.2](v2.10.1...v2.10.2) (2024-12-03)

### Bug Fixes

* setting nullish values on android ([#604](#604)) ([492e4ce](492e4ce))
@Naturalclar
Copy link
Contributor

🎉 This PR is included in version 2.10.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android] onValueChange stopped firing event for false values (null, undefined, 0, "", false, etc)

2 participants