fix: Add deprecated receiveCommand method #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support deprecated receiveCommand which receives commandId as int. It may be RN bug and also dependent on RN version, but running on RN 0.76.2 (old arch), the `receiveCommand` which accepts `String commandId` is never called, therefore calling `focus()` and `blur()` functions does nothing. Here we manually delegate this call using the deprecated `receiveCommand`. JS sends the command id as Int.
Naturalclar
merged commit 0d00e13
into
react-native-picker:master
6 of 12 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
## [2.9.1](v2.9.0...v2.9.1) (2024-11-26) ### Bug Fixes * Add deprecated receiveCommand method ([#601](#601)) ([0d00e13](0d00e13))
Contributor
|
🎉 This PR is included in version 2.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
@Naturalclar I'm in the middle of migrating some lib to new arch and in here I see that they pass a string name for the command (on the old arch), so that's probably how it should be done? That would mean to change this call to this (+ the blur function): I mean, with the change I made, it works too, but maybe this change would be better, since in this PR I override deprecated method? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support deprecated receiveCommand which receives commandId as int.
It may be RN bug and also dependent on RN version, but running on RN 0.76.2 (old arch), the
receiveCommandwhich acceptsString commandIdis never called, therefore callingfocus()andblur()functions does nothing. Here we manually delegate this call using the deprecatedreceiveCommand. JS sends the command id as Int.