chore: code optimization

[li-jia-nan]

Summary by CodeRabbit

发布说明

• 重构
  • 改进了代码的类型安全性，为缓存变量添加了明确的类型注解。
  • 优化了数值检测逻辑，使用更严格的方法进行 NaN 值判断。
  • 调整了导出方式以改进代码可维护性。

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
util	Ready	Preview, Comment	Feb 8, 2026 3:58pm

[gemini-code-assist]

Summary of Changes

Hello @li-jia-nan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on minor code optimizations across several utility files. The changes primarily involve enhancing type safety with explicit type annotations, improving the correctness of numerical checks by using a more robust isNaN variant, and refining code structure for better readability. These adjustments contribute to a more robust and maintainable codebase without altering core functionality.

Highlights

• Type Safety Enhancement: Added a React.CSSProperties type annotation to the cacheOverflow variable in src/PortalWrapper.tsx to improve type checking and maintainability.
• Robust NaN Checking: Updated the src/getScrollBarSize.tsx file to use Number.isNaN instead of the global isNaN function for more accurate and reliable detection of NaN values when calculating scrollbar dimensions.
• Code Structure Refinement: Refactored the default export in src/isMobile.ts by assigning the function to a named constant getIsMobile before exporting it, enhancing code readability and consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/PortalWrapper.tsx
  • Added React.CSSProperties type to cacheOverflow variable.
• src/getScrollBarSize.tsx
  • Replaced isNaN(fallbackWidth) with Number.isNaN(fallbackWidth).
  • Replaced isNaN(fallbackHeight) with Number.isNaN(fallbackHeight).
• src/isMobile.ts
  • Refactored anonymous default export function to a named constant getIsMobile.

Activity

• No human activity (comments, reviews) has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

演进概览

该拉取请求包含三个独立的代码质量改进：TypeScript 类型注解添加、NaN 验证方法升级，以及导出函数的命名规范化。功能逻辑保持不变，涉及跨越三个源文件的小规模更新。

变更内容

队列 / 文件	摘要
类型注解 src/PortalWrapper.tsx	为 cacheOverflow 变量添加显式 TypeScript 类型注解 React.CSSProperties，提高类型安全性。
验证方法优化 src/getScrollBarSize.tsx	将 isNaN() 替换为 Number.isNaN()，对 fallbackWidth 和 fallbackHeight 采用更严格的 NaN 检测。
导出重构 src/isMobile.ts	将匿名默认导出函数改为具名常量 getIsMobile，改进代码可读性和可维护性。

预估代码审查工作量

🎯 2 (简单) | ⏱️ ~8 分钟

建议审查人

• zombieJ

诗歌

🐰✨ 类型更清晰，验证更严谨，
导出有其名，代码更精进。
三处小改良，质量步步前。
兔子为你鼓掌，代码闪闪亮！ 🎉

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	标题'code optimization'过于笼统，未能具体说明本次变更的核心内容。变更涉及三个文件中的特定优化（类型注解、NaN检查方式、导出方式），但标题未体现这些具体改动。	建议使用更具体的标题，如'refactor: improve type safety and export handling in utility functions'，以更清楚地描述实际的代码改动。

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch getIsMobile-update

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request introduces several code optimizations and quality improvements, such as adding explicit types, using Number.isNaN for more robust checks, and refactoring for better readability. The changes are generally positive. I've identified a potential logic issue in getScrollBarSize.tsx where a fallback value of 0 would be incorrectly handled. I've provided suggestions to address this to ensure the logic is robust for all valid scrollbar sizes.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (f07e0d6) to head (2d04986).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #729   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files          38       38           
  Lines        1044     1044           
  Branches      370      385   +15     
=======================================
  Hits          900      900           
  Misses        142      142           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR makes small “optimization”/cleanup changes across utility modules by improving export clarity, strengthening type annotations, and using stricter NaN checks during scrollbar measurement.

Changes:

• Refactors src/isMobile.ts to export a named function (getIsMobile) instead of an anonymous default export.
• Replaces global isNaN with Number.isNaN in scrollbar size calculation.
• Adds an explicit React.CSSProperties type to cacheOverflow in PortalWrapper.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/isMobile.ts	Refactors default export into a named getIsMobile function while preserving caching behavior.
src/getScrollBarSize.tsx	Uses Number.isNaN for fallback scrollbar measurements (but introduces/retains a falsy 0 fallback issue).
src/PortalWrapper.tsx	Tightens typing of cacheOverflow to React.CSSProperties.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.