Skip to content

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 18, 2025

在 antd 侧文档没写,但是 demo 居然用了。防止 break change 补上 afterOpenChange

Summary by CodeRabbit

  • 新功能
    • 新增了一个可选回调接口,允许在预览组件打开或关闭时通知外部状态变化。
  • 测试
    • 优化了图片预览和预览组的测试用例,确保在预览状态改变时新回调能正确触发。

@vercel
Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 6:34am

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

该变更为预览组件添加了新的可选回调函数 afterOpenChange,用于在预览打开或关闭时通知外部状态变化。组件接口和事件处理逻辑相应更新,同时相应的测试用例也进行了调整,以验证在预览状态变更时两个回调 (onOpenChangeafterOpenChange) 均被正确调用。

Changes

文件路径 变更摘要
src/.../index.tsx InternalPreviewConfig 接口中添加 afterOpenChange?: (open: boolean) => void;;在组件的 onVisibleChanged 方法中调用该回调(使用可选链方式)。
tests/preview.test.tsx, tests/.../previewGroup.test.tsx 在测试中增加对 afterOpenChange 的断言,验证预览开启(传入 true)和关闭(传入 false)时该回调被调用,同时更新了 onOpenChange 的断言风格。

Sequence Diagram(s)

sequenceDiagram
    participant U as 用户
    participant P as 预览组件
    participant O as onOpenChange 回调
    participant A as afterOpenChange 回调

    U->>P: 触发预览打开/关闭
    P->>O: 调用 onOpenChange(state)
    P->>A: (如存在)调用 afterOpenChange(state)
Loading

Poem

我是一只跳跃的小兔子,
在代码林中欣赏变化之舞。
新加入的回调如风轻轻送,
打开或关闭都充满奇遇。
我追逐着逻辑与状态,
编码之路洒满星光✨,
欢庆每一次代码的跃动!

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/Preview/index.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct.

The config "prettier" was referenced from the config file in "/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

tests/preview.test.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct.

The config "prettier" was referenced from the config file in "/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

tests/previewGroup.test.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct.

The config "prettier" was referenced from the config file in "/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b48931c and 85dd3da.

📒 Files selected for processing (3)
  • src/Preview/index.tsx (3 hunks)
  • tests/preview.test.tsx (2 hunks)
  • tests/previewGroup.test.tsx (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.40%. Comparing base (b48931c) to head (85dd3da).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          17       17           
  Lines         506      507    +1     
  Branches      149      149           
=======================================
+ Hits          503      504    +1     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zombieJ zombieJ merged commit 11226eb into master Mar 18, 2025
9 of 10 checks passed
@zombieJ zombieJ deleted the afterOpenChange branch March 18, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants