Skip to content

Conversation

@ohjho
Copy link

@ohjho ohjho commented Jul 16, 2024

changed the code in a few places so that it's able to run on CPU

also changed the code formatting a little using Black

@rdroste rdroste merged commit 0440df7 into rdroste:master Jul 16, 2024
@rdroste
Copy link
Owner

rdroste commented Jul 16, 2024

Thx for the contribution!

@ohjho
Copy link
Author

ohjho commented Jul 16, 2024

and thanks for the great model!

i'm using it for a project and making a few additions to make inference of images and videos more streamlined, if you would like I could push those changes into here too

@rdroste
Copy link
Owner

rdroste commented Jul 19, 2024

Thanks for the suggestion. Feel free to open a PR once you have those changes. However, note that this repository needs to replicate the results from our paper, so I can't include changes that affect the accuracy. If the changes are too far-reaching, I can always link to your fork in the README.

@ohjho ohjho deleted the feat/cpu-infer branch July 19, 2024 22:17
@ohjho
Copy link
Author

ohjho commented Jul 19, 2024

yes totally understand, the latest PR #21 only added inference functions, no subtractions, no modification of any of your existing methods or functions (aside from the code formatting for "better" readability).

I focused mostly on image inference for now, will make similar inference support for videos in a future PR

i'm currently testing the use of your model in combination of several different foundation models (e.g. SAM) to get salient objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants