use local structs for data push #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a final version but it attempts to address the main issues found and it got spread to other areas as a result of the initial change
The
push/1&push_list/1functions are not currently using the advantages of having a custom structPushMessage. Even further, both methods are piping the incoming message/s map/s in order to cast them but at the end of each method the orinal passed arguments are sent to Expo.This just means that the incoming data could say anything because something else is being sent. And, also, lists are not being ckunked every 100, so it does't seem to be possible to send more than 100 push notifications
Again, this is not a final version but it may be a place to start the refactor
@rdrop