Modify the typespec for functions push and push_list #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I'll look into this and confirm next week, thanks for the PR |
|
Me too, I ended up dropping this attribute above my function to quiet the error: |
|
Ran into this as well. Would love to get this accepted into the library. Is this still maintained? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this repo!
My dialyzer showed error "breaks the contract" when passing a map or list(map) as the argument for functions PushNotification.push/1 and PushNotification.push_list/1 respectively.
I found out that those functions were expecting the type PushMessage.t() instead of map.
Please let me know what do you guys think!
Kind Regards