-
Notifications
You must be signed in to change notification settings - Fork 0
Include alias name in YamlRunner prog parameter #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adjusts the CLI “prog” value passed to YamlRunner so xts <alias> --help shows correct usage including the alias name, aligning help output with how users actually invoke aliased commands.
Changes:
- Added
_alias_nametoXTSto track the alias used for invocation. - Set
_alias_nameduring first-arg parsing after alias resolution. - Passed
program=f'xts {alias}'intoYamlRunnerso usage includes the alias.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| raise SystemExit(1) | ||
|
|
||
| # load xts config remove alias name from argv before parsing | ||
| self.xts_config = resolved_xts_path | ||
| self._alias_name = alias_name |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utils.error(...) already raises SystemExit(1), so the subsequent raise SystemExit(1) is unreachable. Consider removing the redundant raise to avoid dead code and keep the control flow clear.
Co-authored-by: TB-1993 <109213741+TB-1993@users.noreply.github.com>
Co-authored-by: TB-1993 <109213741+TB-1993@users.noreply.github.com>
Co-authored-by: TB-1993 <109213741+TB-1993@users.noreply.github.com>
Co-authored-by: TB-1993 <109213741+TB-1993@users.noreply.github.com>
3c1b16b to
bdf9f62
Compare
When invoking
xts <alias> --help, the help message showedUsage: xts [-h]instead ofUsage: xts <alias> [-h], making usage examples incorrect for aliased commands.Changes
_alias_nameinstance variable toXTSclass to capture the resolved alias name_parse_first_arg()after resolutionf'xts {self._alias_name}'when initializingYamlRunnerinrun()methodExample
Before:
After:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.