Fix buffer overflow in Vlan_SetMacAddr from int/ULONG type mismatch #29
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix buffer overflow in Vlan_SetMacAddr from int/ULONG type mismatch
Changes
int add = 0;toULONG add = 0;inVlan_SetMacAddr()(PULONG)&add→&addIssue
Vlan_GetEthLinkMacOffSet()expectsPULONG*but receivedint*. On 64-bit systems:ULONG= 8 bytesint= 4 bytesFunction writes 8 bytes into 4-byte location, corrupting adjacent
numbervariable.Impact: MAC
00:33:44:22:00:88→number = 0x3344220088→ corrupts to0x3300000000after function callFixes #24
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.