firewall: clean up reference board #defines / add generic Arm #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic Arm reference platform (meta-rdk-bsp-arm) uses a similar configuration to other reference platforms (Banana Pi and Turris). The setup for these platforms relies on many pre-processor macros like: defined(_PLATFORM_TURRIS_) || defined(_PLATFORM_BANANA_PI) Instead of adding another defined(..) to the source, we will take this opportunity to add a common macro (_GENERIC_LINUX_DATA_PATH_). Many of these tests also apply to the Raspberry Pi RDK-B reference, however, with it's upcoming deprecation we will not touch these references. They will likely disappear in future development work (such as nftables migration). Signed-off-by: Mathew McBride <matt@traverse.com.au>
…upport Similar to the previous commit for the firewall changes, introduce _GENERIC_LINUX_DATA_PATH_ as a substitute for defined(_PLATFORM_BANANA_PI_) where appropriate. This will add support for the generic Arm reference platform and any other future platforms with the same configuration. Signed-off-by: Mathew McBride <matt@traverse.com.au>
mcbridematt
force-pushed
the
upstream-generic-linux-define
branch
from
2788e0e to
9c54df0
Compare
mcbridematt
added a commit
to mcbridematt/meta-rdk-bsp-arm
that referenced
this pull request
Jan 14, 2026
… patch This is rebased on top of Utopia 2.0.0 and the pull request submitted here: rdkcentral/utopia#172
mcbridematt
added a commit
to mcbridematt/meta-rdk-bsp-arm
that referenced
this pull request
Jan 16, 2026
… patch This is rebased on top of Utopia 2.0.0 and the pull request submitted here: rdkcentral/utopia#172
mcbridematt
added a commit
to mcbridematt/meta-rdk-bsp-arm
that referenced
this pull request
Jan 28, 2026
… patch This is rebased on top of Utopia 2.0.0 and the pull request submitted here: rdkcentral/utopia#172
mcbridematt
added a commit
to mcbridematt/meta-rdk-bsp-arm
that referenced
this pull request
Jan 28, 2026
… patch This is rebased on top of Utopia 2.0.0 and the pull request submitted here: rdkcentral/utopia#172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the generic Arm / SystemReady compatible project.
We have carried a few out of tree patches for Utopia which I want to get upstream to reduce our maintenance burden.
Generic ARM hosts do not use a hardware dataplane, so the setup is similar to the RPI, Turris and now the Banana Pi R4.
In parts of Utopia there are a lot of
#definesequences like this:and adding another statement (like
_PLATFORM_GENERICARM_) is just getting messy.I propose to replace it with a common
#definesuch as_GENERIC_LINUX_DATA_PATH_.The substitutions are:
I have revised the patchset to leave references to
_PLATFORM_RASPBERRYPI_alone due to:_PLATFORM_RASPBERRYPI_is used to avoid setting rules for the WAN or LAN side (because the RPI only has one Ethernet port), and in some cases it is difficult to untangle them_PLATFORM_RASPBERRYPI_The above platforms will need to add:
-D_GENERIC_LINUX_DATA_PATH_to their utopia bbappend, like this:
I will mark this PR as draft, please let me know any comments. I am happy to prepare pull requests for the other affected platforms (Banana Pi) in sync with ours.