Merge #87

Vismalskumar0 · 2025-03-27T07:08:31Z

No description provided.

Signed-off-by: Venkata Bojja <venkata_bojja@comcast.com>

RDK-56550 : Add new RFC value for LaunchDarkly env key

L2 test fixes

Reason for change: Fixing L2 in tr69hostif. Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com Signed-off-by: gsanto722 <grandhi_santoshkumar@comcast.com>

CLAassistant · 2025-03-27T07:08:38Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
11 out of 14 committers have signed the CLA.

✅ Abhinavpv28
✅ madhubabutt
✅ nhanasi
✅ leenaS-d
✅ Vismalskumar0
✅ Alan-Ryan
✅ MonekaLakshmi
✅ tpaul627
✅ NareshM1702
✅ apatel859
✅ venkat0557
❌ Venkata Bojja
❌ naveenkumarhanasi
❌ udaykrishnag

Venkata Bojja seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Reason for change:Fix L2 link issue Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

…dkcentral/tr69hostif into feature/RDK-55702-use-pwr-plugin_retry

Reason for change:FIx L2 linking issue. Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

…dkcentral/tr69hostif into feature/RDK-55702-use-pwr-plugin_retry

Reason for change: Fix L2 test Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

Reason for change: Update the MW clients to use Power Manager Plugin Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

Reason for change: Fix L2 and native compilation. Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

…e tr181 parameters (#303) * ES1-2915-[ES1]: xPKI cert creation is failed due to unable to retrieve tr181 parameters ES1-2915-[ES1]: xPKI cert creation is failed due to unable to retrieve tr181 parameters Reason for change:Removing duplicate entries so that rbuscli works for different dm Test Procedure: Check the parameter valuess and ensure rbus commands are working Risks: Medium Priority: P1 Signed-off-by: Vismal S Kumar <VismalSasi_Kumar@comcast.com> * ES1-2915-[ES1]: xPKI cert creation is failed due to unable to retrieve tr181 parameters ES1-2915-[ES1]: xPKI cert creation is failed due to unable to retrieve tr181 parameters Reason for change:Removing duplicate entries so that rbuscli works for different dm Test Procedure: Check the parameter valuess and ensure rbus commands are working Risks: Medium Priority: P1 Signed-off-by: Vismal S Kumar <VismalSasi_Kumar@comcast.com> * Remove ProductClass parameter from data model Removed the 'ProductClass' parameter from the data model. * Remove ProductClass parameter from data-model-tv.xml Removed the ProductClass parameter from the data model. * Add CovaticSDK object with Enable parameter --------- Signed-off-by: Vismal S Kumar <VismalSasi_Kumar@comcast.com>

tr69hostif 1.2.8 release

…/secure (#318) RDKTV-39100 : [SECVULN] migrate configuration files from /opt to /opt/secure Reason for change: Move /opt/parodus_cfg.json to /opt/secure/parodus_cfg.json to avoid security vulnerability Test Procedure: For crud requests, parodus should use /opt/secure/parodus_cfg.json path. Risks: Medium Priority: P1 Signed off by:Vismal S Kumar

Reason for Change: Set the default value of Memcapture to False Co-authored-by: nhanas001c <naveenkumar_hanasi@comcast.com>

* Update test_bootup_sequence.py Enhanced the bootup sequence * Update test_handlers_communications.py * Update tr69hostif_deviceip.py * Refactor WebPA tests with updated payloads and order Updated test order and modified payload URLs in multiple test functions for consistency and to use mock URLs. * Refactor WebPA firmware download URL test Refactor test_WebPA_Get_FWDL_URL_Handler to remove duplicate assertions and streamline the process. * Fix indentation for test_WebPA_Get_FWDL_URL_Handler * Update run_l2.sh * Implement test for RFC defaults file existence Add test for RFC defaults file creation and validation * Update test order in test_handlers_communications.py * Update test execution order for device tests * Update test order for WebPA handlers --------- Co-authored-by: nhanasi <navihansi@gmail.com>

Tr69hostif release from develop for 1.2.9

* Update data-model-generic.xml * Update data-model-generic.xml * Update data-model-generic.xml * Update src/hostif/parodusClient/waldb/data-model/data-model-generic.xml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/hostif/parodusClient/waldb/data-model/data-model-generic.xml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/hostif/parodusClient/waldb/data-model/data-model-generic.xml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/hostif/parodusClient/waldb/data-model/data-model-generic.xml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/hostif/parodusClient/waldb/data-model/data-model-generic.xml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update data-model-generic.xml --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Device_DeviceInfo.cpp * RDK-60387 [tr69hostif] Reduce repetitive logging RDK-60387-[tr69hostif] Reduce repetitive logging Reason for change:Move the Info logs to debug

* Remove alternate ValidateInput_Arguments implementation Removed the alternate implementation of ValidateInput_Arguments function under the RDKV_TR69 preprocessor directive. * Change ExecStart command to use shell execution to force apparmor process file * Change ExecStart to use shell for parodus service * Fix ExecStart command syntax in parodus.service --------- Co-authored-by: Shibu Kakkoth Vayalambron <shibu.kakkoth@gmail.com>

Copilot

Pull request overview

This PR merges various changes including service configuration updates, new test files, refactoring, and bug fixes across the tr69hostif codebase.

Changes:

Modified systemd service files to update dependencies and remove environment variables
Added comprehensive WebPA and DeviceIP functional test suites
Fixed resource leak in get_security_token() function
Added stub implementations for unit testing and gtest support
Updated test helper functions with renamed grep_tr69hostiflogs function

Reviewed changes

Copilot reviewed 150 out of 154 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
tr69hostif.service	Updated service dependencies and execution parameters, added timeout configuration
tr69hostif_no_new_http_server.service	Removed environment variables and script execution from service startup
test/functional-tests/tests/tr69hostif_webpa.py	New comprehensive WebPA handler test suite with mock parodus integration
test/functional-tests/tests/tr69hostif_deviceip.py	New test suite for Device.IP and Device.Services handlers
test/functional-tests/tests/test_handlers_communications.py	Updated test order and renamed helper function calls
test/functional-tests/tests/test_bootup_sequence.py	Expanded bootup validation tests with detailed initialization checks
test/functional-tests/tests/helper_functions.py	Renamed `clear_T2logs` to `clear_tr69hostiflogs` and added `grep_paroduslogs`
src/hostif/src/hostIf_utils.cpp	Fixed resource leak by ensuring `v_secure_pclose` is called; added gtest helper
src/hostif/src/IniFile.cpp	Performance optimization using `std::move`
src/hostif/profiles/wifi/Device_WiFi_SSID.cpp	Added RDKV_NM support and fixed field name from "isEnabled" to "enabled"
src/unittest/stubs/*	Added numerous stub files for unit testing infrastructure
src/integrationtest/conf/*	Added configuration files for integration testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-15T20:38:28Z

src/hostif/src/hostIf_utils.cpp

             }
-         }
+        }
+	v_secure_pclose(pSecurity);


Inconsistent indentation: this line uses a tab character while surrounding code uses spaces. This should use consistent indentation (spaces) to match the rest of the file.

Copilot · 2026-01-15T20:38:28Z

src/hostif/profiles/wifi/Device_WiFi_SSID.cpp

            	        ERR_CHK(rc);
        	    }
-		    cJSON *isEnabled = cJSON_GetObjectItem(interface, "isEnabled");
+		    cJSON *isEnabled = cJSON_GetObjectItem(interface, "enabled");


Variable name isEnabled is misleading as it now retrieves the 'enabled' field. Consider renaming the variable to enabled or enabledField to match the JSON field name being accessed.

Copilot · 2026-01-15T20:38:28Z

src/hostif/profiles/wifi/Device_WiFi_SSID.cpp

+	if(rc!=EOK)
+    	{
+	    ERR_CHK(rc);
+    	}


Inconsistent indentation using both tabs and spaces throughout this function. The code should use consistent indentation style (either all spaces or all tabs, matching the project convention).

Copilot · 2026-01-15T20:38:29Z

test/functional-tests/tests/tr69hostif_webpa.py

+@pytest.mark.run(order=44) 
+def test_WebPA_Set_FirmwareToDownload_For_Upgrade():
+    print("Starting parodus mock process - Set firmware to download") 
+    payload = '{"command":"SET","parameters":[{"name":"Device.DeviceInfo.X_RDKCENTRAL-COM_FirmwareToDownload","dataType":0,"value":"    TESTIMAGE_DEV.bin"}]}'


The value for FirmwareToDownload contains leading spaces (' TESTIMAGE_DEV.bin'). This appears unintentional and could cause issues. The value should likely be 'TESTIMAGE_DEV.bin' without leading whitespace.

Copilot · 2026-01-15T20:38:29Z

test/functional-tests/features/tr69hostif_webpa.feature

+Feature: WebPA Set Get using mock parodus
+
+  Background:
+    Given the mock parodus executable is avaliable at "/usr/local/bin/parodus"


Corrected spelling of 'available' from 'avaliable'.

Copilot · 2026-01-15T20:38:30Z

test/functional-tests/tests/test_bootup_sequence.py

+    assert RFC_PARAM_LINE in file_content, f"Expected parameter '{RFC_PARAM_NAME}' not found in {RFC_DEFAULTS_FILE}"
+
+    #Get the parameter value from that file
+    param_value = rbus_get_data(RFC_PARAM_NAME)


Variable param_value is not used.

Copilot · 2026-01-15T20:38:30Z

test/functional-tests/tests/tr69hostif_deviceip.py

+import pytest
+from time import sleep
+
+from helper_functions import *


Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

Copilot · 2026-01-15T20:38:30Z

test/functional-tests/tests/tr69hostif_webpa.py

+import pytest
+from time import sleep
+
+from helper_functions import *


Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

Copilot · 2026-01-15T20:38:31Z

test/functional-tests/tests/tr69hostif_deviceip.py

+####################################################################################
+
+
+import subprocess


Import of 'subprocess' is not used.

Copilot · 2026-01-15T20:38:31Z

test/functional-tests/tests/tr69hostif_deviceip.py

+
+import subprocess
+import pytest
+from time import sleep


Import of 'sleep' is not used.

Tr69hostif 1.3.0 version release

* Update Device_DeviceInfo.h * Update Device_DeviceInfo.h * Update Device_DeviceInfo.h * Update Device_DeviceInfo.h * Update Device_DeviceInfo.h * Update Device_DeviceInfo.h * Update Device_DeviceInfo.h * Update Device_DeviceInfo.h * Update Device_DeviceInfo.h * Update Device_DeviceInfo.h

Copilot

Pull request overview

Copilot reviewed 150 out of 154 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T19:55:59Z

dependent_rdk_pkg_installer.sh

+git clone https://github.com/xmidt-org/trower-base64.git
+cd trower-base64
+meson setup build
+ninja -C build
+ninja -C build install
+cd $WORKDIR
+rm -rf trower-base64
+
+# cJson flavor used in RDK stack
+cd $WORKDIR
+git clone https://github.com/DaveGamble/cJSON.git
+cd cJSON
+mkdir build
+cd build
+cmake ..
+make && make install
+cd $WORKDIR
+rm -rf cJSON
+
+# Include WDMP package
+cd $WORKDIR
+git clone https://github.com/xmidt-org/wdmp-c.git
+cd wdmp-c
+sed -i '/WDMP_ERR_SESSION_IN_PROGRESS/a\    WDMP_ERR_INTERNAL_ERROR,\n    WDMP_ERR_DEFAULT_VALUE,' src/wdmp-c.h
+cmake -H. -Bbuild -DBUILD_FOR_DESKTOP=ON -DCMAKE_BUILD_TYPE=Debug
+make -C build && make -C build install
+cd $WORKDIR 
+rm -rf wdmp-c
+
+# Install dependencies of libparodus
+cd $WORKDIR
+git clone https://github.com/nanomsg/nanomsg.git
+cd nanomsg
+mkdir build
+cd build
+cmake ..
+cmake --build .
+cmake --build . --target install
+cd $WORKDIR
+rm -rf nanomsg
+
+git clone https://github.com/xmidt-org/cimplog.git
+cd cimplog
+git checkout 8a5fb3c2f182241d17f5342bea5b7688c28cd1fd
+mkdir build
+cd build
+cmake ..
+make && make install
+cd $WORKDIR
+rm -rf cimplog
+
+
+cd $WORKDIR 
+git clone https://github.com/xmidt-org/wrp-c.git
+cd wrp-c
+git checkout 9587e8db33dbbfcd9b78ef66cc2eaf16dfb9afcf
+# replace  7a98138f27f27290e680bf8fbf1f8d1b089bf138 with 445880108a1d171f755ff6ac77e03fbebbb23729 in CMakeLists.txt
+# Message pack revision used in libparadous is not buildable with latest gcc versions
+sed -i 's/7a98138f27f27290e680bf8fbf1f8d1b089bf138/445880108a1d171f755ff6ac77e03fbebbb23729/g' CMakeLists.txt
+mkdir build
+cd build
+cmake ..
+make && make install
+cd $WORKDIR
+rm -rf wrp-c
+
+cd $WORKDIR 
+git clone https://github.com/xmidt-org/libparodus.git
+cd libparodus
+# replace  7a98138f27f27290e680bf8fbf1f8d1b089bf138 with 445880108a1d171f755ff6ac77e03fbebbb23729 in CMakeLists.txt
+# Message pack revision used in libparadous is not buildable with latest gcc versions
+sed -i 's/7a98138f27f27290e680bf8fbf1f8d1b089bf138/445880108a1d171f755ff6ac77e03fbebbb23729/g' CMakeLists.txt
+mkdir build
+cd build
+cmake ..
+make && make install
+cd $WORKDIR 
+rm -rf libparodus


The dependent_rdk_pkg_installer.sh script clones and builds several third-party projects (e.g. trower-base64, cJSON, wdmp-c, nanomsg) directly from mutable GitHub branches/tags without pinning to immutable commits or verifying integrity, then installs them into the build/runtime environment. If any of these upstream repositories are compromised or force-pushed, an attacker could inject malicious code that is built and executed in your CI or developer environments, potentially compromising build artifacts or secrets. To mitigate this supply-chain risk, pin each git clone to a specific trusted commit or release tag and, where possible, add checksum/signature verification before building and installing.

Co-authored-by: nhanasi <navihansi@gmail.com>

Venkata Bojja and others added 6 commits March 26, 2025 21:21

RDK-56550 : Add new RFC value for LaunchDarkly env key

bfda4f1

Signed-off-by: Venkata Bojja <venkata_bojja@comcast.com>

Merge pull request #84 from rdkcentral/topic/RDK-56550

df2c832

RDK-56550 : Add new RFC value for LaunchDarkly env key

1.0.14 release changelog updates

6ffeb93

Merge branch 'release/1.0.14'

aab946a

Merge tag '1.0.14' into develop

62fc551

L2 test fixes

RDK-55702: Update the MW clients to use Power Manager Plugin

405cff1

Reason for change: Fixing L2 in tr69hostif. Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com Signed-off-by: gsanto722 <grandhi_santoshkumar@comcast.com>

Vismalskumar0 requested review from a team March 27, 2025 07:08

santoshcomcast and others added 21 commits March 27, 2025 10:14

RDK-55702: Update the MW clients to use Power Manager Plugin

31f5888

Reason for change:Fix L2 link issue Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

RDK-55702: Update the MW clients to use Power Manager Plugin

2ff572c

Reason for change:Fix L2 link issue Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

Merge branch 'feature/RDK-55702-use-pwr-plugin_retry' of github.com:r…

aa225dc

…dkcentral/tr69hostif into feature/RDK-55702-use-pwr-plugin_retry

Merge branch 'develop' into feature/RDK-55702-use-pwr-plugin_retry

e7fa114

RDK-55702: Update the MW clients to use Power Manager Plugin

b20b527

Reason for change:FIx L2 linking issue. Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

Merge branch 'feature/RDK-55702-use-pwr-plugin_retry' of github.com:r…

52e53cb

…dkcentral/tr69hostif into feature/RDK-55702-use-pwr-plugin_retry

RDK-55702: Update the MW clients to use Power Manager Plugin

e7efde1

Reason for change: Fix L2 test Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

Merge remote-tracking branch 'origin/develop' into topic/RDK52635

bf31756

Update run_l2.sh

ffb78bf

Update run_l2.sh

af17cc1

RDK-55702: Update the MW clients to use Power Manager Plugin

08527a0

Reason for change: Update the MW clients to use Power Manager Plugin Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

RDK-55702: Update the MW clients to use Power Manager Plugin

a6cfa9b

Reason for change: Fix L2 and native compilation. Test Procedure: Refer RDK-55702 Risks: Low Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

Update run_l2.sh

e0a747f

Update run_l2.sh

449df8c

Update run_l2.sh

01869b2

Update run_l2.sh

01e374e

Update run_l2.sh

8d7f0df

Update helper_functions.py

37e48e4

Update test_bootup_sequence.py

d401d6c

Update helper_functions.py

5023d3b

Update test_bootup_sequence.py

5644439

Vismalskumar0 and others added 16 commits October 28, 2025 15:35

RDKEMW-9754: DAC bundle config parameter as RFC (#304)

6509c4b

1.2.8 release changelog updates

0717da2

Merge branch 'release/1.2.8'

d05547a

Merge tag '1.2.8' into develop

77b380c

tr69hostif 1.2.8 release

Fixing the bug for ethernet interface (#309)

c6427d7

RDKEMW-6128: Update hostIf_IARM_ReqHandler.cpp (#312)

8d3162c

RDKEMW-10639: Convert memcapture tool as RDM downloadable package (#320)

36c98ae

Reason for Change: Set the default value of Memcapture to False Co-authored-by: nhanas001c <naveenkumar_hanasi@comcast.com>

1.2.9 release changelog updates

79e3a45

Merge branch 'release/1.2.9'

89a89cf

Merge tag '1.2.9' into develop

3fbb483

Tr69hostif release from develop for 1.2.9

RDK-60387-[tr69hostif] Reduce repetitive logging (#334)

24c9c68

* Update Device_DeviceInfo.cpp * RDK-60387 [tr69hostif] Reduce repetitive logging RDK-60387-[tr69hostif] Reduce repetitive logging Reason for change:Move the Info logs to debug

Copilot AI review requested due to automatic review settings January 15, 2026 20:35

Copilot started reviewing on behalf of nhanasi January 15, 2026 20:35 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

naveenkumarhanasi and others added 4 commits January 16, 2026 18:05

1.3.0 release changelog updates

dd7a7f7

Merge branch 'release/1.3.0'

c3dec43

Merge tag '1.3.0' into develop

711a0e4

Tr69hostif 1.3.0 version release

Copilot AI review requested due to automatic review settings February 5, 2026 19:51

Copilot started reviewing on behalf of nhanasi February 5, 2026 19:51 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

Update hostIf_main.cpp (#344)

4db1b2c

Co-authored-by: nhanasi <navihansi@gmail.com>

shibu-kv deleted the branch feature/RDK52635 February 6, 2026 21:12

shibu-kv closed this Feb 6, 2026

github-actions bot locked and limited conversation to collaborators Feb 6, 2026

		####################################################################################


		import subprocess

Merge #87

Merge #87

Uh oh!

Conversation

Vismalskumar0 commented Mar 27, 2025

Uh oh!

CLAassistant commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

CLAassistant commented Mar 27, 2025 •

edited

Loading